fix create block send message view #38571

nkdengineer · 2024-03-19T11:41:25Z

Details

Issue: Access the PRIVATE_BLOCKED_FROM_CHAT NVP to block the UI for adding comments

Fixed Issues

$ #37688
PROPOSAL: #37688 (comment)

Tests

Login with [email protected], that is blocked by internal team here
Open any report. Verify that text "Note: You have been banned from communicating in this channel" is displayed and the composer is not displayed.

Verify that no errors appear in the JS console

Offline tests

QA Steps

Login with [email protected], that is blocked by internal team here
Open any report. Verify that text "Note: You have been banned from communicating in this channel" is displayed and the composer is not displayed.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2024-05-27.at.15.15.00.mov

Android: mWeb Chrome

Screen.Recording.2024-05-27.at.15.19.47.mov

iOS: Native

Screen.Recording.2024-05-27.at.15.14.27.mov

iOS: mWeb Safari

Screen.Recording.2024-05-27.at.15.18.38.mov

MacOS: Chrome / Safari

Screen.Recording.2024-05-27.at.15.13.20.mov

MacOS: Desktop

Screen.Recording.2024-05-27.at.15.13.57.mov

luacmartins · 2024-04-09T18:10:11Z

@nkdengineer what's the next step here?

luacmartins · 2024-04-11T15:43:01Z

@nkdengineer any updates?

nkdengineer · 2024-04-11T16:11:10Z

@luacmartins We're still discussing in the issue #37688 (comment).

melvin-bot · 2024-05-27T07:49:42Z

@shubham1206agra Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

shubham1206agra · 2024-05-28T11:44:20Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

shubham1206agra · 2024-05-28T11:44:56Z

@nkdengineer Can you get translation confirmation here?

luacmartins · 2024-05-28T14:23:04Z

I asked for translations in Slack. Gonna update here if there are any changes needed.

luacmartins · 2024-05-28T15:33:32Z

Translations are good!

OSBotify · 2024-05-28T15:57:06Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-05-29T09:41:45Z

🚀 Deployed to staging by https://github.com/luacmartins in version: 1.4.77-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

kbecciv · 2024-05-29T10:40:01Z

@luacmartins Is it Internal QA?
We need a magic code to log in to a specific account:
Step 1: Log in with [email protected].

OSBotify · 2024-05-30T21:24:34Z

🚀 Deployed to production by https://github.com/puneetlath in version: 1.4.77-11 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-05-30T22:36:32Z

🚀 Deployed to production by https://github.com/puneetlath in version: 1.4.77-11 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

wildan-m · 2024-06-03T02:20:30Z

Hi, one of my test account blocked from any chat.

It show Note: You have been banned from communicating in this channel on every chat

What condition that make the account blocked and how to unblock it?

the account: [email protected]

shubham1206agra · 2024-06-03T02:35:24Z

@wildan-m Can you please show what is written on nvp_private_blockedFromChat Onyx key?

wildan-m · 2024-06-03T02:37:45Z

@shubham1206agra

wildan-m · 2024-06-03T02:38:36Z

I've tried to re-login, but it keep blocked

roryabraham · 2024-06-04T23:57:58Z

src/pages/home/report/ReportFooter.tsx

@@ -153,6 +158,7 @@ function ReportFooter({
                        />
                    )}
                    {isArchivedRoom && <ArchivedReportFooter report={report} />}
+                    {!isArchivedRoom && blockedFromChat && <BlockedReportFooter />}


This is causing a console error on main (may crash on iOS/Android):

Unexpected text node: . A text node cannot be a child of a <View>.

@roryabraham Can you tell me how to reproduce the bug, pls?

created #43083 to fix it

Just open any report

nkdengineer added 4 commits March 19, 2024 18:32

fix create block send message view

6590db4

fix merge main

07c7338

fix add translations

fa5e9e8

fix lint

383f8f9

luacmartins self-requested a review April 8, 2024 19:48

nkdengineer added 2 commits May 27, 2024 14:29

fix merge main

6478fe7

fix conflict

ca31854

nkdengineer marked this pull request as ready for review May 27, 2024 07:49

nkdengineer requested a review from a team as a code owner May 27, 2024 07:49

melvin-bot bot requested review from shubham1206agra and removed request for a team May 27, 2024 07:49

nkdengineer mentioned this pull request May 27, 2024

[HOLD for payment 2024-06-06] [$500] Access the PRIVATE_BLOCKED_FROM_CHAT NVP to block the UI for adding comments #37688

Closed

6 tasks

nkdengineer added 2 commits May 27, 2024 14:59

fix type

e718d2d

fix banner issue

88bc2c6

luacmartins approved these changes May 28, 2024

View reviewed changes

shubham1206agra approved these changes May 28, 2024

View reviewed changes

melvin-bot bot requested a review from luacmartins May 28, 2024 15:40

luacmartins approved these changes May 28, 2024

View reviewed changes

luacmartins merged commit f6de985 into Expensify:main May 28, 2024
19 checks passed

github-actions bot mentioned this pull request May 29, 2024

Deploy Checklist: New Expensify 2024-05-29 #42741

Closed

roryabraham reviewed Jun 4, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix create block send message view #38571

fix create block send message view #38571

nkdengineer commented Mar 19, 2024 •

edited

Loading

luacmartins commented Apr 9, 2024

luacmartins commented Apr 11, 2024

nkdengineer commented Apr 11, 2024

melvin-bot bot commented May 27, 2024

shubham1206agra commented May 28, 2024

shubham1206agra commented May 28, 2024

luacmartins commented May 28, 2024

luacmartins commented May 28, 2024

OSBotify commented May 28, 2024

OSBotify commented May 29, 2024

kbecciv commented May 29, 2024

OSBotify commented May 30, 2024

OSBotify commented May 30, 2024

wildan-m commented Jun 3, 2024

shubham1206agra commented Jun 3, 2024

wildan-m commented Jun 3, 2024

wildan-m commented Jun 3, 2024

roryabraham Jun 4, 2024 •

edited

Loading

nkdengineer Jun 5, 2024

roryabraham Jun 5, 2024

roryabraham Jun 5, 2024

fix create block send message view #38571

fix create block send message view #38571

Conversation

nkdengineer commented Mar 19, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

luacmartins commented Apr 9, 2024

luacmartins commented Apr 11, 2024

nkdengineer commented Apr 11, 2024

melvin-bot bot commented May 27, 2024

shubham1206agra commented May 28, 2024

Reviewer Checklist

Screenshots/Videos

shubham1206agra commented May 28, 2024

luacmartins commented May 28, 2024

luacmartins commented May 28, 2024

OSBotify commented May 28, 2024

OSBotify commented May 29, 2024

kbecciv commented May 29, 2024

OSBotify commented May 30, 2024

OSBotify commented May 30, 2024

wildan-m commented Jun 3, 2024

shubham1206agra commented Jun 3, 2024

wildan-m commented Jun 3, 2024

wildan-m commented Jun 3, 2024

roryabraham Jun 4, 2024 • edited Loading

Choose a reason for hiding this comment

nkdengineer Jun 5, 2024

Choose a reason for hiding this comment

roryabraham Jun 5, 2024

Choose a reason for hiding this comment

roryabraham Jun 5, 2024

Choose a reason for hiding this comment

nkdengineer commented Mar 19, 2024 •

edited

Loading

roryabraham Jun 4, 2024 •

edited

Loading