[NO QA] Fullstory integration #40484

danieldoglas · 2024-04-18T17:22:20Z

Details

Fullstory integration

React-Native Android
React-Native IOS
React-Native Web

Functionality included:

Mobile Pages API
Session recording
Essential Identity resolution

What's not included:

Cross-platform build automation at babel.config.js
native parameter should be switched to false for web/desktop (line 26)

['@fullstory/babel-plugin-annotate-react', {
native: false,
setFSTagName: true,
},],
GTM Tag for web/desktop should be configured according to:
https://app.fullstory.com/ui/o-1WN56P-na1/settings/general

Issue:

$ #40784

Tests

Verify that no errors appear in the JS console
Verify App launches without any issues,
Verify transition between states without any issues

QA Steps

PR Author Checklist

Screenshots/Videos

Android: Native

https://drive.google.com/file/d/1rU2BYJ_AW5ibyqlNl-GhG5T2V7f71vCi/view?usp=drive_link

iOS: Native

https://drive.google.com/file/d/1HSQzY1uBctBuh1V-uEGy7dRVMuoIYD3D/view?usp=drive_link https://drive.google.com/file/d/1ClGEI9TD8EdbNFjKwRSEEzlmh3MyM3AL/view?usp=drive_link

MacOS: Chrome / Safari

https://drive.google.com/file/d/1p0lqYvh2Ynl_HhwaLLsaBFTfs-8YyaHZ/view?usp=drive_link

MacOS: Desktop

https://drive.google.com/file/d/1Ymg0aQSsXhbuiZCAd9LLbt1FlMySMjsn/view?usp=drive_link

- React-Native Android - React-Native IOS - Web Functionality included: - Session recording - Essential Identity resolution Functionality added: - FSPage - Mobile Pages API Platforms affected: - Android - IOs Typescript types definitions added. Unit test fixed, fixed eslint errors. Signed-off-by: Oleksii Vagin <[email protected]>

Fullstory integration

melvin-bot · 2024-04-18T17:22:46Z

@francoisl Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

danieldoglas · 2024-04-18T21:58:46Z

@francoisl we're waiting on a e2e test to run on this before merging, and I'll do the reviews.

ishpaul777 · 2024-04-23T12:39:25Z

👋 hello i'll be reviewing this

ishpaul777 · 2024-04-23T14:22:03Z

src/libs/fullstory/index.native.ts

+                    displayName: session.email,
+                    email: session.email,


dont we want to remove email from here ?

Not for now, in a following PR we will change all properties that are being added here. I'm working on returning those properties from the backend

Actually you are correct - I didn't notice we had two files and I thought you were talking about the email in line 27. Fixing it

ishpaul777 · 2024-04-23T14:37:32Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

VIDEO-2024-04-23-21-48-01.mp4

Android: mWeb Chrome

VIDEO-2024-04-23-21-49-02.mp4

iOS: Native

Screen.Recording.2024-04-23.at.9.03.24.PM.mov

iOS: mWeb Safari

Screen.Recording.2024-04-23.at.7.54.10.PM.mov

MacOS: Chrome / Safari

Screen.Recording.2024-04-23.at.8.05.50.PM.mov

MacOS: Desktop

Screen.Recording.2024-04-23.at.9.03.24.PM-1.mov

melvin-bot · 2024-04-23T16:22:58Z

@grgia Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

melvin-bot · 2024-04-23T16:23:02Z

🎯 @ishpaul777, thanks for reviewing and testing this PR! 🎉

An E/App issue has been created to issue payment here: #40809.

luacmartins · 2024-04-23T17:05:23Z

src/libs/fullstory/index.native.ts

+            FullStory.consent(true);
+            FS.fsIdentify(session);
+        } catch (e) {
+            // error handler


NAB seems like we're not properly handling errors here. I think this is fine for now, but maybe we should log something here.

luacmartins · 2024-04-23T17:06:17Z

src/libs/fullstory/index.ts

+                FS.fsIdentify(session);
+            });
+        } catch (e) {
+            // error handler


OSBotify · 2024-04-24T00:07:35Z

🚀 Deployed to staging by https://github.com/luacmartins in version: 1.4.65-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

kbecciv · 2024-04-24T01:16:51Z

@danieldoglas Could someone please verify this PR internally? The QA team doesn't have access to Fullstory.

danieldoglas · 2024-04-24T11:59:18Z

@kbecciv I've checked it off the checklist, this is basically just in production builds and added internal QA here.

kbecciv · 2024-04-24T12:51:28Z

Thank you!

OSBotify · 2024-04-25T13:45:55Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.4.65-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

LCOleksii and others added 6 commits April 18, 2024 16:22

Eslint errors fixed

039884d

Typecheck errors fixed

9a991fc

Eslint errors fixed

6fcb514

Eslint errors fixed

78522e9

Merge pull request #40294 from LCOleksii/fullstory-integration

1928c3a

Fullstory integration

danieldoglas requested a review from a team as a code owner April 18, 2024 17:22

melvin-bot bot requested review from francoisl and removed request for a team April 18, 2024 17:22

danieldoglas removed the request for review from francoisl April 18, 2024 21:58

staszekscp mentioned this pull request Apr 19, 2024

[NoQA] [CI/CD] Fix merging on E2E Performance Tests #40540

Merged

48 tasks

Merge branch 'main' into fullstory-integration

a2f7fcd

mountiny self-requested a review April 23, 2024 12:40

removing email from identification

18358c4

danieldoglas requested a review from ishpaul777 April 23, 2024 14:20

ishpaul777 reviewed Apr 23, 2024

View reviewed changes

removing email from native implementation

1ce4272

ishpaul777 approved these changes Apr 23, 2024

View reviewed changes

melvin-bot bot requested a review from grgia April 23, 2024 16:22

melvin-bot bot mentioned this pull request Apr 23, 2024

Payment issue for E/App PR#40484 #40809

Closed

luacmartins approved these changes Apr 23, 2024

View reviewed changes

luacmartins merged commit df57111 into main Apr 23, 2024
19 checks passed

luacmartins deleted the fullstory-integration branch April 23, 2024 17:08

github-actions bot mentioned this pull request Apr 23, 2024

Deploy Checklist: New Expensify 2024-04-23 #40843

Closed

74 tasks

danieldoglas added the InternalQA This pull request required internal QA label Apr 24, 2024

danieldoglas changed the title ~~Fullstory integration~~ [NO QA] Fullstory integration Apr 24, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[NO QA] Fullstory integration #40484

[NO QA] Fullstory integration #40484

danieldoglas commented Apr 18, 2024 •

edited

Loading

melvin-bot bot commented Apr 18, 2024

danieldoglas commented Apr 18, 2024

ishpaul777 commented Apr 23, 2024

ishpaul777 Apr 23, 2024

danieldoglas Apr 23, 2024

danieldoglas Apr 23, 2024

ishpaul777 commented Apr 23, 2024 •

edited

Loading

melvin-bot bot commented Apr 23, 2024

melvin-bot bot commented Apr 23, 2024

luacmartins Apr 23, 2024

luacmartins Apr 23, 2024

OSBotify commented Apr 24, 2024

kbecciv commented Apr 24, 2024

danieldoglas commented Apr 24, 2024

kbecciv commented Apr 24, 2024

OSBotify commented Apr 25, 2024

[NO QA] Fullstory integration #40484

[NO QA] Fullstory integration #40484

Conversation

danieldoglas commented Apr 18, 2024 • edited Loading

Details

Issue:

Tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Apr 18, 2024

danieldoglas commented Apr 18, 2024

ishpaul777 commented Apr 23, 2024

ishpaul777 Apr 23, 2024

Choose a reason for hiding this comment

danieldoglas Apr 23, 2024

Choose a reason for hiding this comment

danieldoglas Apr 23, 2024

Choose a reason for hiding this comment

ishpaul777 commented Apr 23, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

melvin-bot bot commented Apr 23, 2024

melvin-bot bot commented Apr 23, 2024

luacmartins Apr 23, 2024

Choose a reason for hiding this comment

luacmartins Apr 23, 2024

Choose a reason for hiding this comment

OSBotify commented Apr 24, 2024

kbecciv commented Apr 24, 2024

danieldoglas commented Apr 24, 2024

kbecciv commented Apr 24, 2024

OSBotify commented Apr 25, 2024

danieldoglas commented Apr 18, 2024 •

edited

Loading

ishpaul777 commented Apr 23, 2024 •

edited

Loading