-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ReportNameValuePairs key to Report Type #40661
Merged
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
09f4b6a
Add ReportNameValuePairs key to Report Type
srikarparsi 90e68d2
move to const
srikarparsi 8f1a2e7
Merge branch 'main' into srikar-reportNameValuePairs
srikarparsi d55a329
prettier
srikarparsi 2a6712a
Merge branch 'srikar-reportNameValuePairs' of https://github.com/Expe…
srikarparsi a8694d1
inline type
srikarparsi 2990a7d
remove uneeded import
srikarparsi 9899133
merge main
srikarparsi 108b99c
Merge branch 'main' into srikar-reportNameValuePairs
srikarparsi c80ef8b
move report actions to own onyx structure
srikarparsi 675f944
remove uneeded isArchived in Report
srikarparsi 64544aa
style
srikarparsi 85e9375
incorporate isArchived and bug fixes
srikarparsi 01b7d31
remove testing view
srikarparsi f880524
fix type and cleanup logs
srikarparsi 1f01ef6
prettier
srikarparsi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
import type * as OnyxCommon from './OnyxCommon'; | ||
|
||
type ReportNameValuePairs = OnyxCommon.OnyxValueWithOfflineFeedback<{ | ||
isArchived: boolean; | ||
}>; | ||
|
||
export default ReportNameValuePairs; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to delete this (and the report param) at some point, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes we do, I put some information about that in the "Plan of action" section of his Design Doc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok please do not forget (I'd create an issue, but I have no memory)