Handle deleted reports for Quick Actions #41474

Gonals · 2024-05-02T04:08:52Z

Details

Fixed Issues

$ #41467
PROPOSAL:

Tests

Log into Newdot
Create a new workspace
Submit an expense to the workspace
Log into oldDot and delete the workspace
Log out of Newdot and log back in to make sure all the data is up to date
Click the Submit Expense quick button (it may be lacking info, since we don't automatically load archived reports):

7. Follow the process and confirm you see this:

Repeat the steps for the Submit Scan and Submit distance flows.
Do the same for Track flows (in a workspace chat)
Do the same for the Assign task flow (in a workspace). Confirm the message displays like so:

Verify that no errors appear in the JS console

Offline tests

None

QA Steps

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2024-05-02T04:08:57Z

@rojiphil Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

rojiphil

Overall, the code looks good although there are type check and lint failures to be fixed.
I have also left some review comments for consideration.

src/pages/home/sidebar/SidebarScreen/FloatingActionButtonAndPopover.tsx

src/languages/types.ts

rojiphil · 2024-05-02T08:30:05Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

MacOS: Chrome / Safari

Manual

41474-web-safari-M.mp4

Scan

41474-web-safari-S.mp4

Distance

41474-web-safari-D.mp4

Task

41474-web-safari-T.mp4

MacOS: Desktop

Distance

41474-desktop-D.mp4

Task

41474-desktop-T.mp4

Android: Native

Distance

41474-android-native-D.mp4

Task

41474-android-native-T.mp4

Android: mWeb Chrome

41474-mweb-chrome-M.mp4

iOS: Native

41474-ios-native-D.mp4

iOS: mWeb Safari

41474-mweb-safari-T.mp4

Gonals · 2024-05-03T06:16:22Z

Hey @rojiphil, thanks for the review, but this isn't quite ready yet! When we are still working on a PR, we often mark it as [WIP] (Work in progress). I'll let you know when this is ready!

Gonals · 2024-05-03T08:15:56Z

OFF WIP @rojiphil

rojiphil

I have left some review comments for your consideration. But the code looks good and close to the finish line though.

rojiphil · 2024-05-03T12:01:57Z

src/libs/actions/Task.ts

@@ -703,7 +704,7 @@ function setAssigneeValue(

        // If there is no share destination set, automatically set it to the assignee chat report
        // This allows for a much quicker process when creating a new task and is likely the desired share destination most times
-        if (!shareToReportID) {
+        if (!shareToReportID && !skipShareDestination) {


I may be missing something here but as shareToReportID will be empty in our case, will this not work without the need for skipShareDestination?

Ah, not quite. If skipShareDestination is set, we do NOT want to populate this, as it populates by default to the user's chat, which is not what we want in this flow

src/libs/actions/Task.ts

Gonals · 2024-05-06T03:05:54Z

Comments addressed! Let's see if we can get this done today, @rojiphil!

rojiphil

Thanks @Gonals. LGTM and tests well too.
I have added the test videos and completed the checklist.

melvin-bot · 2024-05-06T11:02:07Z

@amyevans Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

rojiphil · 2024-05-06T14:20:11Z

@Gonals Sorry. I missed adding the header to the reviewer checklist because of which I think the PR checklist is failing. I have added it just now. Now, wondering how to make the checklist succeed

Gonals · 2024-05-06T14:27:01Z

All good! I can rerun the checks 😁

amyevans

Looks good!

OSBotify · 2024-05-06T14:41:19Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-05-09T02:12:12Z

🚀 Deployed to production by https://github.com/marcaaron in version: 1.4.71-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

allgandalf · 2024-08-27T06:19:55Z

src/libs/actions/Task.ts

@@ -735,7 +736,7 @@ function clearOutTaskInfoAndNavigate(reportID?: string, chatReport?: OnyxEntry<O
    }
    if (accountID > 0) {
        const accountLogin = allPersonalDetails?.[accountID]?.login ?? '';
-        setAssigneeValue(accountLogin, accountID, reportID, chatReport);
+        setAssigneeValue(accountLogin, accountID, reportID, chatReport, false, skipConfirmation);


We should had checked if accountID === currentUserAccountID instead of directly passing false here, this caused #47680

Gonals added 7 commits May 2, 2024 12:02

Use random report if the original one is missing

816308e

add message

8563915

get skipConfirmation in participants step

1493562

Display message

c640bc6

cleanup

f195ecd

Spanish

b6e1cef

prettier

2fe5979

Gonals self-assigned this May 2, 2024

Gonals requested a review from a team as a code owner May 2, 2024 04:08

melvin-bot bot requested review from rojiphil and removed request for a team May 2, 2024 04:08

rojiphil reviewed May 2, 2024

View reviewed changes

src/pages/home/sidebar/SidebarScreen/FloatingActionButtonAndPopover.tsx Show resolved Hide resolved

src/languages/types.ts Outdated Show resolved Hide resolved

display report name

7419763

Gonals added 7 commits May 3, 2024 16:23

Merge branch 'main' into alberto-deletedChat

ef90be5

update copies

f9eab94

lint

459f299

Display for tasks too

17f12d2

prettier

f4e94b7

uneeded translation param

620f3f6

bunch of unneeded imports

00e5f49

Gonals changed the title ~~[WIP] Handle deleted reports for Quick Actions~~ Handle deleted reports for Quick Actions May 3, 2024

Gonals mentioned this pull request May 3, 2024

[$500] [QAB] Shortcut - Request money shortcut for workspace remains after workspace is deleted #39051

Closed

6 tasks

rojiphil reviewed May 3, 2024

View reviewed changes

Gonals added 2 commits May 6, 2024 11:55

Merge branch 'main' into alberto-deletedChat

60e2781

pass correct param

644a2ed

rojiphil approved these changes May 6, 2024

View reviewed changes

melvin-bot bot requested a review from amyevans May 6, 2024 11:02

amyevans approved these changes May 6, 2024

View reviewed changes

amyevans merged commit 8c224a4 into main May 6, 2024
16 checks passed

amyevans deleted the alberto-deletedChat branch May 6, 2024 14:34

github-actions bot mentioned this pull request May 7, 2024

Deploy Checklist: New Expensify 2024-05-07 #41716

Closed

rojiphil mentioned this pull request May 23, 2024

[Awaiting Payment 23rd May] [QAB] 404 when clicked if your quick action button is set to a workspace that’s since been deleted #41467

Closed

6 tasks

allgandalf reviewed Aug 27, 2024

View reviewed changes

allgandalf mentioned this pull request Aug 27, 2024

[HOLD for payment 2024-08-29] [$250] Error while task creation via QAB when assigning task to yourself #47680

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Handle deleted reports for Quick Actions #41474

Handle deleted reports for Quick Actions #41474

Gonals commented May 2, 2024 •

edited

Loading

melvin-bot bot commented May 2, 2024

rojiphil left a comment

rojiphil commented May 2, 2024 •

edited

Loading

Gonals commented May 3, 2024

Gonals commented May 3, 2024

rojiphil left a comment

rojiphil May 3, 2024

Gonals May 6, 2024

Gonals commented May 6, 2024

rojiphil left a comment

melvin-bot bot commented May 6, 2024

rojiphil commented May 6, 2024

Gonals commented May 6, 2024

amyevans left a comment

OSBotify commented May 6, 2024

OSBotify commented May 9, 2024

allgandalf Aug 27, 2024

Handle deleted reports for Quick Actions #41474

Handle deleted reports for Quick Actions #41474

Conversation

Gonals commented May 2, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented May 2, 2024

rojiphil left a comment

Choose a reason for hiding this comment

rojiphil commented May 2, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

Gonals commented May 3, 2024

Gonals commented May 3, 2024

rojiphil left a comment

Choose a reason for hiding this comment

rojiphil May 3, 2024

Choose a reason for hiding this comment

Gonals May 6, 2024

Choose a reason for hiding this comment

Gonals commented May 6, 2024

rojiphil left a comment

Choose a reason for hiding this comment

melvin-bot bot commented May 6, 2024

rojiphil commented May 6, 2024

Gonals commented May 6, 2024

amyevans left a comment

Choose a reason for hiding this comment

OSBotify commented May 6, 2024

OSBotify commented May 9, 2024

allgandalf Aug 27, 2024

Choose a reason for hiding this comment

Gonals commented May 2, 2024 •

edited

Loading

rojiphil commented May 2, 2024 •

edited

Loading