Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show time and date in the preferred locale #4316

Merged
merged 4 commits into from
Jul 30, 2021

Conversation

aman-atg
Copy link
Contributor

@aman-atg aman-atg commented Jul 29, 2021

Details

(Comment)

Fixed Issues

$ #4219

Tests || ### QA Steps

Tested On

  • Web
  • Mobile Web
  • Android
  • Can't test on these two
  • Desktop
  • iOS

Screenshots

Web

image
image

Mobile Web

mWeb1
mWeb2
mWeb3
mWeb4

Desktop

iOS

Android

androidTest.mp4

@aman-atg aman-atg requested a review from a team as a code owner July 29, 2021 23:50
@MelvinBot MelvinBot requested review from jasperhuangg and removed request for a team July 29, 2021 23:50
Copy link
Contributor

@jasperhuangg jasperhuangg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good! I also tested them on Desktop and iOS and they work well 👍

@jasperhuangg jasperhuangg merged commit 2444fdd into Expensify:main Jul 30, 2021
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@aman-atg
Copy link
Contributor Author

Thanks a lot for testing it out ❤️

@OSBotify
Copy link
Contributor

🚀 Deployed to staging in version: 1.0.81-5🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Aug 6, 2021

🚀 Deployed to production in version: 1.0.82-7🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants