Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update XCode to fix iOS deploy #4339

Merged
merged 5 commits into from
Aug 2, 2021
Merged

Update XCode to fix iOS deploy #4339

merged 5 commits into from
Aug 2, 2021

Conversation

Jag96
Copy link
Contributor

@Jag96 Jag96 commented Jul 30, 2021

cc @roryabraham

Details

This PR updates the XCode version to fix an issue where fastlane is failing because of a mismatch.

Fixed Issues

$ #4337

Tests

Building the app and archiving it works fine for me, so the next best way to test this is to merge and confirm the deploy doesn't fail

QA Steps

None

Tested On

  • iOS

Screenshots

N/A

@Jag96 Jag96 requested a review from AndrewGable July 30, 2021 21:59
@Jag96 Jag96 requested a review from a team as a code owner July 30, 2021 21:59
@Jag96 Jag96 self-assigned this Jul 30, 2021
@MelvinBot MelvinBot removed the request for review from a team July 30, 2021 21:59
Jag96
Jag96 commented Jul 30, 2021
View reviewed changes
ios/Podfile.lock
@@ -564,7 +564,7 @@ PODS:
- UMCore
- UMConstantsInterface (6.1.0):
- UMCore
- UMCore (7.1.0)
- UMCore (7.1.1)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These automatically updated when running pod install

@MelvinBot MelvinBot requested a review from aldo-expensify July 30, 2021 21:59
AndrewGable
AndrewGable previously approved these changes Jul 30, 2021
View reviewed changes
@Jag96
Copy link
Contributor Author

Jag96 commented Jul 30, 2021

Looks like e2e fails now, will likely have to fix broken dependencies 👀

@Jag96 Jag96 marked this pull request as draft July 30, 2021 22:02
@Jag96
Copy link
Contributor Author

Jag96 commented Jul 30, 2021

From the failing build, looks like /Applications/Xcode_12.5.app/ doesn't have anything there

Fetching aws-sdk-kms 1.43.0
Installing aws-sdk-kms 1.43.0
Gem::Ext::BuildError: ERROR: Failed to build gem native extension.

current directory:
/Users/runner/work/App/App/vendor/bundle/ruby/2.7.0/gems/json-2.5.1/ext/json/ext/generator
/Users/runner/hostedtoolcache/Ruby/2.7.4/x64/bin/ruby -I
/Users/runner/hostedtoolcache/Ruby/2.7.4/x64/lib/ruby/2.7.0 -r
./siteconf20210730-1267-rn4l0w.rb extconf.rb
creating Makefile

current directory:
/Users/runner/work/App/App/vendor/bundle/ruby/2.7.0/gems/json-2.5.1/ext/json/ext/generator
make "DESTDIR=" clean
xcrun: error: missing DEVELOPER_DIR path:
/Applications/Xcode_12.5.app/Contents/Developer

current directory:
/Users/runner/work/App/App/vendor/bundle/ruby/2.7.0/gems/json-2.5.1/ext/json/ext/generator
make "DESTDIR="
xcrun: error: missing DEVELOPER_DIR path:
/Applications/Xcode_12.5.app/Contents/Developer

make failed, exit code 1

@Jag96
Copy link
Contributor Author

Jag96 commented Jul 30, 2021

Looks like GH actions available versions only go up to 12.4 for macos-latest which is 10.15:

So for 12.5 we'd have to update to macos-11 per https://github.com/actions/virtual-environments#available-environments

Going to give that a shot and see what the result is

@Jag96
Copy link
Contributor Author

Jag96 commented Jul 30, 2021

Looks like we need to match the schemas in https://json.schemastore.org/github-workflow.json, so macos-11.0 instead of macos-11. However, that seems to break the e2e (which didn't break with macos-11). I believe we'll have to update the validateActionsAndWorkflows script to fix this cc @roryabraham.

image

@aldo-expensify
Copy link
Contributor

Sorry @Jag96 , I don't know how to test this, and it will take me some time to figure it out. I'll be off on Monday, so you may want to choose someone with more experience to review this :)

@roryabraham
Copy link
Contributor

Great investigation so far @Jag96!

I believe we'll have to update the validateActionsAndWorkflows script to fix this cc @roryabraham.

Okay, I guess for now the best thing to do might be to:

  1. Switch back to runs-on: macos-11
  2. Just disable that check in our CI/CD for now
  3. Submit a PR against schemastore to update the JSON schema.
  4. Once that PR is merged, re-enable the schema verification.

@roryabraham roryabraham mentioned this pull request Aug 2, 2021
Merged
@roryabraham
Copy link
Contributor

SchemaStore PR here

@roryabraham
Copy link
Contributor

Whoa, the SchemaStore PR is already merged, so the schema validation check is passing ✅ 🎉

@Jag96 Jag96 marked this pull request as ready for review August 2, 2021 16:50
@Jag96
Copy link
Contributor Author

Jag96 commented Aug 2, 2021

Putting this into review, looks like e2e got past the part where it was previously failing so this should be good 🤞

@Jag96 Jag96 requested a review from roryabraham August 2, 2021 16:50
roryabraham
roryabraham approved these changes Aug 2, 2021
View reviewed changes
Copy link
Contributor

@roryabraham roryabraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, this seems pretty simple – update the runners to macos-11 and xcode to 12.5. Hopefully this works!

@AndrewGable AndrewGable merged commit 8db44bc into main Aug 2, 2021
@AndrewGable AndrewGable deleted the joe-update-xcode-version branch August 2, 2021 17:15
@OSBotify
Copy link
Contributor

OSBotify commented Aug 2, 2021

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify OSBotify mentioned this pull request Aug 2, 2021
Closed
100 tasks
github-actions bot pushed a commit that referenced this pull request Aug 2, 2021
@AndrewGable
Merge pull request #4339 from Expensify/joe-update-xcode-version
c0b3d7e 
Update XCode to fix iOS deploy

(cherry picked from commit 8db44bc)
@OSBotify OSBotify mentioned this pull request Aug 2, 2021
Merged
@OSBotify
Copy link
Contributor

OSBotify commented Aug 2, 2021

🚀 Deployed to staging in version: 1.0.82-2🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify OSBotify mentioned this pull request Aug 6, 2021
Closed
89 tasks
@OSBotify
Copy link
Contributor

OSBotify commented Aug 6, 2021

🚀 Deployed to production in version: 1.0.82-7🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Aug 6, 2021

🚀 Deployed to staging in version: 1.0.82-8🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify OSBotify mentioned this pull request Aug 11, 2021
Closed
53 tasks
@OSBotify
Copy link
Contributor

🚀 Deployed to production by @francoisl in version: 1.0.83-1 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 failure ❌
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify OSBotify mentioned this pull request Aug 17, 2021
Closed
This was referenced Aug 25, 2021
Closed
Closed
This was referenced Sep 2, 2021
Closed
Closed
@roryabraham roryabraham mentioned this pull request Aug 1, 2022
Merged
93 tasks
@OSBotify OSBotify mentioned this pull request Aug 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roryabraham roryabraham roryabraham approved these changes

@AndrewGable AndrewGable AndrewGable approved these changes

@aldo-expensify aldo-expensify Awaiting requested review from aldo-expensify

Assignees

@Jag96 Jag96

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Jag96 @aldo-expensify @roryabraham @OSBotify @AndrewGable