-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[No QA] Switch warnCPLabel trigger from pull_request to pull_request_target #4370
Conversation
Does it still need |
I think just |
Changing it would also have the side-effect of the comment not being left by |
Which is "more secure" or "more secret"? |
I think |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Okay, beginning testing now |
One reminder for the test steps, I think your |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
So if we see this fail on contributor fork's, I think they will have to merge |
Step 2 (regression test) passed: #4380 |
Nice, step 3 passed: #4381 |
🚀 Deployed to staging in version: 1.0.82-8🚀
|
🚀 Deployed to production by @francoisl in version: 1.0.83-1 🚀
|
Details
The
warnCPLabel.yml
workflow has been failing on any PR from a fork. This PR should fix that.More discussion here.
Fixed Issues
$ n/a
Tests
CP Staging
label.OSBotify
should comment on the PR explaining the implications of theCP Staging Label
.CP Staging
label.OSBotify
should comment on the PR explaining the implications of theCP Staging Label
.Tested On
n/a – Live testing in GH only.