Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure workspaces show after signing in #4444

Merged
merged 1 commit into from
Aug 6, 2021
Merged

Conversation

Jag96
Copy link
Contributor

@Jag96 Jag96 commented Aug 6, 2021

Details

We weren't resetting a variable after signing out, which caused policies to not load after signing out and signing back in. This PR fixes that.

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/173118#

Tests/QA

  1. Launch web in an incognito window and sign in, confirm that after signing in the user's workspaces show on the Settings page
  2. Sign out and sign back in, confirm that the workspaces show on the Settings page

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web/Desktop

image

Mobile

image

@Jag96 Jag96 self-assigned this Aug 6, 2021
@Jag96 Jag96 requested a review from a team as a code owner August 6, 2021 02:25
@MelvinBot MelvinBot requested review from MonilBhavsar and removed request for a team August 6, 2021 02:25
@MonilBhavsar MonilBhavsar merged commit e0b91c9 into main Aug 6, 2021
@MonilBhavsar MonilBhavsar deleted the joe-sign-in-workspaces branch August 6, 2021 13:19
@OSBotify
Copy link
Contributor

OSBotify commented Aug 6, 2021

🚀 Deployed to staging in version: 1.0.82-11🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @francoisl in version: 1.0.83-1 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 failure ❌
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants