Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy update #4473

Merged
merged 1 commit into from
Aug 9, 2021
Merged

Copy update #4473

merged 1 commit into from
Aug 9, 2021

Conversation

chiragsalian
Copy link
Contributor

@chiragsalian chiragsalian commented Aug 6, 2021

Updated copy,
Screen Shot 2021-08-06 at 2 55 08 PM

Details

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/173188

Tests

Self tested by putting an incorrect industry classification code

QA Steps

None

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

@chiragsalian chiragsalian self-assigned this Aug 6, 2021
@chiragsalian chiragsalian marked this pull request as ready for review August 6, 2021 21:56
@chiragsalian chiragsalian requested a review from a team as a code owner August 6, 2021 21:56
@MelvinBot MelvinBot requested review from sketchydroide and removed request for a team August 6, 2021 21:56
Copy link
Contributor

@sketchydroide sketchydroide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sketchydroide sketchydroide merged commit 34ba515 into main Aug 9, 2021
@sketchydroide sketchydroide deleted the chirag-classification-copy-update branch August 9, 2021 09:31
@OSBotify
Copy link
Contributor

OSBotify commented Aug 9, 2021

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @sketchydroide in version: 1.0.83-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 failure ❌
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @isagoico in version: 1.0.85-9 🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants