-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the password label in Plaid VBA flow #4530
Conversation
@shawnborton You are right! I have raised the issue in here, but that was a wrong place probably. The thing is that there was no label originally. What label would you propose for this select, or should I ask in #product? |
I think it could simply say "Account" or "Choose account" - looks like @roryabraham also reported this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Details
See the issue for more context.
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/173525
$ #4548
Tests
How to test it locally: SO here.
Follow the
Log Into Your Bank
flow inAdd Bank Account
, login in through Plaid, selectPlaid Saving
and make sure the password field saysEnter Expensify password
if English is selected as your language.QA Steps
Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android