Settings - Left hand menu and RHP do not open instantly when opening from link #45778

WojtekBoman · 2024-07-19T13:42:42Z

Details

This PR fixes displaying LHN and RHP when opening a link to the RHP page in Settings.
When launching the app from the deeplink, we always pushed Home page at the bottom of the BottomTabNavigator, it has been removed as it was no longer necessary and was causing delays.

Comparison of opening link with and without the fix:

Screen.Recording.2024-07-19.at.16.02.53.mov

Fixed Issues

$ #44585
PROPOSAL:

Tests

Open the link: https://staging.new.expensify.com/settings/preferences/priority-mode
Check if the app opens without lag in LHN and RHP

Verify that no errors appear in the JS console

Offline tests

❌

QA Steps

Open the link: https://dev.new.expensify.com:8082/settings/preferences/priority-mode
Check if the app opens without lag in LHN and RHP

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2024-07-19.at.15.45.23.mov

Android: mWeb Chrome

Screen.Recording.2024-07-19.at.15.47.09.mov

iOS: Native

Screen.Recording.2024-07-19.at.16.09.30.mov

iOS: mWeb Safari

Screen.Recording.2024-07-19.at.15.34.47.mov

MacOS: Chrome / Safari

Screen.Recording.2024-07-19.at.16.02.53.mov

MacOS: Desktop

Screen.Recording.2024-07-19.at.15.50.10.mov

melvin-bot · 2024-07-19T14:12:54Z

@ishpaul777 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

ishpaul777 · 2024-07-19T16:02:30Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Record_2024-07-20-00-53-12.mp4

Android: mWeb Chrome

Screen.Recording.2024-07-19.at.11.33.47.PM.mov

iOS: Native

Screen.Recording.2024-07-19.at.9.51.42.PM.mov

iOS: mWeb Safari

Screen.Recording.2024-07-19.at.9.48.13.PM.mov

MacOS: Chrome / Safari

Screen.Recording.2024-07-19.at.9.44.22.PM.mov

MacOS: Desktop

Screen.Recording.2024-07-20.at.12.50.41.AM.mov

ishpaul777 · 2024-07-19T16:11:44Z

hello @WojtekBoman, Thanks for the PR it does fix the issue 🎉

we always pushed Home page at the bottom of the BottomTabNavigator, it has been removed as it was no longer necessary

before i approve could you help me understand why we were doing this and why not necessary anymore. Thanks!

WojtekBoman · 2024-07-22T12:07:46Z

hello @WojtekBoman, Thanks for the PR it does fix the issue 🎉

we always pushed Home page at the bottom of the BottomTabNavigator, it has been removed as it was no longer necessary

before i approve could you help me understand why we were doing this and why not necessary anymore. Thanks!

Previously, the application used the Onyx state ONYXKEYS.IS_SIDEBAR_LOADED to determine when to hide the splash screen. It was set to true on the Home screen, so it always had to be in the navigation state when the application started. This logic has already been removed so we can refactor it

ishpaul777 · 2024-07-22T13:13:57Z

it make sense, Thanks for clarifying!

OSBotify · 2024-07-22T18:57:44Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-07-23T08:37:20Z

🚀 Deployed to staging by https://github.com/marcaaron in version: 9.0.11-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

mvtglobally · 2024-07-23T14:19:15Z

@marcaaron Do we need to validate anything in Staging here?

marcaaron · 2024-07-23T23:49:41Z

yes, updated the description

OSBotify · 2024-07-24T00:17:38Z

🚀 Cherry-picked to staging by https://github.com/francoisl in version: 9.0.11-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2024-07-25T03:18:30Z

🚀 Deployed to production by https://github.com/francoisl in version: 9.0.11-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-07-26T05:15:28Z

🚀 Deployed to production by https://github.com/francoisl in version: 9.0.12-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Fix createBottomTabNavigator

9969f59

WojtekBoman marked this pull request as ready for review July 19, 2024 14:12

WojtekBoman requested a review from a team as a code owner July 19, 2024 14:12

melvin-bot bot removed the request for review from a team July 19, 2024 14:12

melvin-bot bot requested a review from ishpaul777 July 19, 2024 14:12

ishpaul777 approved these changes Jul 22, 2024

View reviewed changes

melvin-bot bot requested a review from marcaaron July 22, 2024 13:13

marcaaron approved these changes Jul 22, 2024

View reviewed changes

marcaaron merged commit 485332d into Expensify:main Jul 22, 2024
19 of 22 checks passed

github-actions bot mentioned this pull request Jul 23, 2024

Deploy Checklist: New Expensify 2024-07-23 #45991

Closed

95 tasks

melvin-bot bot mentioned this pull request Jul 25, 2024

[HOLD for payment 2024-08-01] [$250] Settings - Left hand menu and RHP do not open instantly when opening from link #44585

Closed

6 tasks

ishpaul777 mentioned this pull request Aug 3, 2024

Enable React concurrent mode #42592

Merged

48 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Settings - Left hand menu and RHP do not open instantly when opening from link #45778

Settings - Left hand menu and RHP do not open instantly when opening from link #45778

WojtekBoman commented Jul 19, 2024 •

edited by marcaaron

Loading

melvin-bot bot commented Jul 19, 2024

ishpaul777 commented Jul 19, 2024 •

edited

Loading

ishpaul777 commented Jul 19, 2024 •

edited

Loading

WojtekBoman commented Jul 22, 2024

ishpaul777 commented Jul 22, 2024

OSBotify commented Jul 22, 2024

OSBotify commented Jul 23, 2024

mvtglobally commented Jul 23, 2024

marcaaron commented Jul 23, 2024

OSBotify commented Jul 24, 2024

OSBotify commented Jul 25, 2024

OSBotify commented Jul 26, 2024

Settings - Left hand menu and RHP do not open instantly when opening from link #45778

Settings - Left hand menu and RHP do not open instantly when opening from link #45778

Conversation

WojtekBoman commented Jul 19, 2024 • edited by marcaaron Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jul 19, 2024

ishpaul777 commented Jul 19, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

ishpaul777 commented Jul 19, 2024 • edited Loading

WojtekBoman commented Jul 22, 2024

ishpaul777 commented Jul 22, 2024

OSBotify commented Jul 22, 2024

OSBotify commented Jul 23, 2024

mvtglobally commented Jul 23, 2024

marcaaron commented Jul 23, 2024

OSBotify commented Jul 24, 2024

OSBotify commented Jul 25, 2024

OSBotify commented Jul 26, 2024

WojtekBoman commented Jul 19, 2024 •

edited by marcaaron

Loading

ishpaul777 commented Jul 19, 2024 •

edited

Loading

ishpaul777 commented Jul 19, 2024 •

edited

Loading