Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD] Fix translation for (edited) label in chat #4679

Closed
wants to merge 2 commits into from

Conversation

aldo-expensify
Copy link
Contributor

@aldo-expensify aldo-expensify commented Aug 16, 2021

@pecanoro

Details

Fix translation for (edited) label in chat when a user edit a message they already sent

Fixed Issues

$ #4518

Tests

  1. Send a message in chat
  2. Edit the message
  3. A label with grey font should display (edited) if the user configured the app language to 'English'. If the user configured the app language to Spanish, it should display (editado)

QA Steps

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Screen Shot 2021-08-16 at 11 34 27 AM

Screen Shot 2021-08-16 at 11 36 33 AM

Mobile Web

Desktop

Screen Shot 2021-08-16 at 11 48 25 AM

Screen Shot 2021-08-16 at 11 48 40 AM

iOS

Android

@aldo-expensify aldo-expensify requested a review from a team as a code owner August 16, 2021 18:38
@MelvinBot MelvinBot requested review from timszot and removed request for a team August 16, 2021 18:38
@aldo-expensify aldo-expensify changed the title Fix translation for (edited) label in chat [HOLD] Fix translation for (edited) label in chat Aug 16, 2021
@aldo-expensify aldo-expensify removed the request for review from timszot August 16, 2021 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant