-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[No QA] Post deploy announcements in slack #4757
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we also post prod deploys in #expensify-open-source?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @luacmartins, I'm unsure how to test this without causing havoc with the current release. Should we merge and use internal testing to verify against the next official release and CP?
Updated! Added the step to post prod deploys to
@Julesssss I think that might be the only way. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could do with some more emoji
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I agree with @Julesssss that it's lacking in emoji.
Live-testing changes like this always requires some patience and persistence. You don't necessarily have follow the testing instructions to the T in order to verify it works, just remember to verify it when CPs / staging deploys / prod deploys happen.
Good points, will keep an eye out for this. Merging now. |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to production by @roryabraham in version: 1.0.88-2 🚀
|
Seems to be working! |
cc @roryabraham will you please take a look?
Details
Posts an announcement in the
#announce
Slack channel after app is deployed to staging and production.Fixed Issues
$ #4727
Tests
StagingDeployCash
is not locked.StagingDeployCash
, then verify that the resulting staging deploy is announced in#announce
.CP Staging
label, then verify that the resulting staging deploy is announced in#announce
.#announce
.QA Steps
None.
Tested On
N/A GitHub only!