[No QA] Tag mobile deployers instead of @here in #announce for deploy failures #4767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomatoToaster
approved these changes
Aug 20, 2021
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
This was referenced Aug 24, 2021
|
🚀 Deployed to production by @roryabraham in version: 1.0.88-2 🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@AndrewGable will you please review?
Details
This PR updates the pings in #announce to ping mobile deployers instead of
@herefor workflow failures. Got the mobile deployer subgroup from https://github.com/Expensify/Mobile-Deploy/blob/master/notify.js#L114Fixed Issues
Discussion in https://expensify.slack.com/archives/C03V9A4TB/p1629476458374500
Tests
N/A, will confirm this live
QA Steps
N/A