Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Web Safari Signin page layout #4802

Merged
merged 5 commits into from
Aug 27, 2021
Merged

Fix Web Safari Signin page layout #4802

merged 5 commits into from
Aug 27, 2021
+20 −4

Conversation

mananjadhav
Copy link
Collaborator

@mananjadhav mananjadhav commented Aug 24, 2021 •
edited
Loading

@johnmlee101 Can you please review this?

Details

Fixed Issues

$ #4110

Tests

  1. Tested the Signin page on Chrome, Safari, Firefox
  2. Tested on Mobile browsers for any breaks
  3. Tested on iPad

QA Steps

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

chrome-web

firefox-web

safari-web

Mobile Web

mweb

ipad-mweb

Desktop

desktop

iOS

ios

Android

Screenshot 2021-08-24 at 10 47 12 PM

Sorry, something went wrong.

@mananjadhav mananjadhav requested a review from a team as a code owner August 24, 2021 17:17
@MelvinBot MelvinBot requested review from nickmurray47 and removed request for a team August 24, 2021 17:18
nickmurray47
nickmurray47 previously approved these changes Aug 26, 2021
View reviewed changes
Copy link
Contributor

@nickmurray47 nickmurray47 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM but looks like there's some merge conflicts that need to be resolved

@mananjadhav
Merge branch 'main' of https://github.com/mananjadhav/App into fix/si…
5e62d66 
…gnin-page-layout

# Conflicts:
#	src/components/withWindowDimensions.js
#	src/styles/variables.js
@mananjadhav
Copy link
Collaborator Author

@nickmurray47 Resolved conflicts and PR updated

@nickmurray47 nickmurray47 merged commit e0497e3 into Expensify:main Aug 27, 2021
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify OSBotify mentioned this pull request Aug 27, 2021
Closed
@kevinksullivan
Copy link
Contributor

Waiting till this has been deployed to prod for 7 days.

@mananjadhav mananjadhav mentioned this pull request Aug 30, 2021
Closed
@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @nickmurray47 in version: 1.0.88-3 🚀

platform result
🤖 android 🤖 cancelled 🔪
🖥 desktop 🖥 cancelled 🔪
🍎 iOS 🍎 cancelled 🔪
🕸 web 🕸 success ✅

@Jag96
Copy link
Contributor

Jag96 commented Aug 31, 2021

@mananjadhav it looks like there is a warning on the sign-in page related to this, can you please fix?

image

@OSBotify
Copy link
Contributor

OSBotify commented Sep 1, 2021

🚀 Deployed to production by @roryabraham in version: 1.0.90-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@mananjadhav mananjadhav mentioned this pull request Sep 1, 2021
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickmurray47 nickmurray47

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mananjadhav @OSBotify @kevinksullivan @Jag96 @nickmurray47