Remove expensifySMS domain from the request IOU page

[parasharrajat]

Details

1. Removed the SMS domain from the UI,
2. Fix the logic for IOU request creation to send the full form of phone numbers. (Revert of Fix IOU request sent to new phone number account #3651)

Fixed Issues

$ #4435

Tests | QA Steps

1. open staging.new.expensify.com in chrome.
2. go to chat with a user where their account login is a phone number
3. click the plus icon next to the compose box (not the big green one)
4. enter the amount
5. observe User details.

1

6. There should be no @expensify.sms with the phone number.

2

7. Test that you can not request money with yourself. Try entering the phone number or phone number with the SMS domain.

3

8. Try to make an IOU request with a user using a phone number that does not exist in NewDot.

Tested On

• Web
• Mobile Web
• Desktop
• iOS
• Android

Screenshots

Web | Desktop

Mobile Web

iOS

Android

[Julesssss]

Too busy to review this today due to internal project, will review tomorrow.

[Julesssss]

Looks good and tests well

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[OSBotify]

🚀 Deployed to staging by @Julesssss in version: 1.0.90-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[botify]

This has been deployed to production and is now subject to a 7-day regression period.
If no regressions arise, payment will be issued on 2021-09-08. 🎊

[OSBotify]

🚀 Deployed to production by @roryabraham in version: 1.0.91-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅