Undo conversion of errorAttemptsCount to object

[NikkiWines]

cc: @marcaaron

Details

Follow up PR to https://github.com/Expensify/Web-Secure/pull/2022 to clean out some old, no longer needed logic.

Fixed Issues

$ #4889 (comment)

Tests

1. Set isPlaidTestAccountNumbers() and isPlaidTestRequestor() and inlib/ACHData.phpto returnfalse` so that we run the some necessary checks
2. Run through the QA steps

QA

1. Log into an account on new.expensify.com without a bank account set up
2. Navigate to /bank-account
3. Click on Connect Manually and enter the credentials for a PENDING bank account from this SO post
   • 
4. Once you get to the Requestor step confirm that you get the Please verify your name and date of birth. If the information is correct, click "Save & Continue error once
5. Resubmit your information and confirm you're routed to the next view and not looped back to the requestor step again

Tested On

• Web
• Mobile Web
• Desktop
• iOS
• Android

Screenshots

Web

Screen.Recording.2021-08-30.at.5.30.13.PM.mov

Mobile Web

Desktop

iOS

Android

[NikkiWines]

Off hold!

[OSBotify]

🚀 Deployed to staging by @MonilBhavsar in version: 1.0.92-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

[isagoico]

@NikkiWines Hello! I'm getting the error message in a modal instead of a Growl, I was comparing with the video you attached in the main comment but not sure if this has to do with the PR or not

[marcaaron]

cc @aldo-expensify this is probably expected and related to the changes we are making?

[NikkiWines]

I believe it's fine @isagoico since I know we were moving away from growls for bank account set up, but let's wait for @aldo-expensify to confirm just in case!

[roryabraham]

Pretty confident that:

1. This is expected behavior
2. If unexpected, it's not caused by this PR.

So in lieu of input from @aldo-expensify I'm going to check this off.

[aldo-expensify]

This is expected behaviour, we changed that growl for the modal here

[OSBotify]

🚀 Deployed to production by @roryabraham in version: 1.0.93-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅