[A/B Testing][ESLint Clean Up] Use useOnyx cases for files in combinedTrackSubmit #49592

fabioh8010 · 2024-09-23T10:29:17Z

Details

cc @grgia

This PR migrates the touched components from #49007 to useOnyx:

AccessOrNotFoundWrapper
AttachmentPickerWithMenuItems
FloatingActionButtonAndPopover
IOURequestStepAmount
IOURequestStepDistance
IOURequestStepScan
IOURequestStepParticipants
ReportWelcomeText

Fixed Issues

$ #49593
PROPOSAL: #49007 (comment)

Tests

AccessOrNotFoundWrapper

Navigate to a non-existent workspace by URL / deep link (/settings/workspaces/999999/profile).
Assert the Not Found page is shown.

AttachmentPickerWithMenuItems

Go to any chat.
Click the + button to open the meny and assert all the options shown work as expected.

FloatingActionButtonAndPopover

Click the Global Create button to open the menu.
Assert all the options shown work as expected.

IOURequestStepAmount / IOURequestStepParticipants

Click the Global Create button to open the menu and start submit an expense.
Go to the Manual tab, assert you can insert an amount and change the currency.
Assert there is a list of participants and choose one.
Assert you are able to navigate to the confirmation page and finish the flow.

IOURequestStepScan

Start submit, track or split an expense.
Go to the Scan tab, assert you can upload a receipt.
Assert you are able to navigate to the confirmation page and finish the flow.

IOURequestStepDistance

Start submit, track or split an expense.
Go to the Distance tab, assert you can insert a start and stop address for the map.
Assert you are able to navigate to the confirmation page and finish the flow.

ReportWelcomeText

Go to a chat with another user.
Assert the welcome text is displayed.

Verify that no errors appear in the JS console

Offline tests

Same.

QA Steps

Same.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2024-10-03.at.11.55.52-compressed.mov

Android: mWeb Chrome

Screen.Recording.2024-10-03.at.12.00.45-compressed.mov

iOS: Native

Screen.Recording.2024-10-03.at.12.13.53-compressed.mov

iOS: mWeb Safari

Screen.Recording.2024-10-03.at.12.20.30-compressed.mov

MacOS: Chrome / Safari

Screen.Recording.2024-10-03.at.12.22.41-compressed.mov

Screen.Recording.2024-10-03.at.12.26.05-compressed.mov

MacOS: Desktop

Screen.Recording.2024-10-03.at.12.29.32-compressed.mov

grgia · 2024-09-23T10:33:59Z

@fabioh8010 I created a separate issue for tracking here

grgia · 2024-09-23T10:37:54Z

@fabioh8010 let me know when this PR is ready for review and a test build. I'd like to try and get this one merged ASAP as we need to merge the component to start testing

fabioh8010 · 2024-09-25T06:37:57Z

@grgia I will put this on HOLD once #49007 is completed.

grgia · 2024-10-01T13:57:52Z

@fabioh8010, could we start a review on this? I can create a test build

…-migration

…nse-flow-48787-withOnyx-migration

melvin-bot · 2024-10-03T11:34:39Z

@MonilBhavsar Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

MonilBhavsar

Looks good

fabioh8010 · 2024-10-11T17:00:23Z

Infinite loading on accessing `https://dev.new.expensify.com:8082/settings/workspaces/fffjdlkdsjl/distance-rates`

@shubham1206agra I'm not being able to reproduce this

Screen.Recording.2024-10-11.at.17.17.28.mov

fabioh8010 · 2024-10-11T17:00:54Z

I am unable to record the video, but I am seeing blank screen on refresh of amount page.

@shubham1206agra Could you share which platform you tested and reproduction steps for this?

shubham1206agra · 2024-10-11T17:06:10Z

I am unable to record the video, but I am seeing blank screen on refresh of amount page.

@shubham1206agra Could you share which platform you tested and reproduction steps for this?

Web

Go to FAB > Submit Expense.
Click on Manual
Refresh the page

shubham1206agra · 2024-10-14T03:19:21Z

Screen.Recording.2024-10-14.at.8.47.40.AM.mov

@fabioh8010 Please look at this video. Try to throttle the CPU to notice this. Maybe add loading indicator.

…-migration

fabioh8010 · 2024-10-14T16:33:17Z

@shubham1206agra I'm having consistent behavior during the refresh between main and this branch (tested with throttling), could you check if you have same behavior on main?

main

Screen.Recording.2024-10-14.at.17.26.54.mov

branch

Screen.Recording.2024-10-14.at.17.28.08.mov

shubham1206agra · 2024-10-16T07:02:41Z

@fabioh8010 Can you please fox the tests for IOURequestStepDistance?

fabioh8010 · 2024-10-16T07:57:54Z

@shubham1206agra Fixed!

MonilBhavsar · 2024-10-18T07:39:32Z

@shubham1206agra over to you

…-migration

shubham1206agra · 2024-10-19T09:40:43Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

Screen.Recording.2024-10-19.at.1.37.01.PM.mov

iOS: Native

Screen.Recording.2024-10-19.at.6.32.24.PM.mov

iOS: mWeb Safari

Screen.Recording.2024-10-19.at.1.23.12.PM.mov

MacOS: Chrome / Safari

Screen.Recording.2024-10-19.at.1.04.33.PM.mov

MacOS: Desktop

Screen.Recording.2024-10-19.at.1.43.00.PM.mov

MonilBhavsar

Thanks!

melvin-bot · 2024-10-21T07:49:56Z

@grgia looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

grgia · 2024-10-21T07:51:34Z

Hmm, all tests were passing when I merged. Looks like the test was skipped? But should be fine.

OSBotify · 2024-10-21T07:59:30Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2024-10-22T04:47:45Z

🚀 Deployed to staging by https://github.com/grgia in version: 9.0.52-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

IuliiaHerets · 2024-10-22T12:54:13Z

This PR is failing because of issue #51247

Julesssss · 2024-10-22T12:54:19Z

Reverted this PR here, as it introduced a deploy blocker -- Track Expense option wasn't shown to expensifail (or all private domain) users

github-actions · 2024-10-23T16:25:12Z

🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.0.52-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

fabioh8010 added 8 commits September 23, 2024 11:00

Migrate AccessOrNotFoundWrapper to useOnyx

372c348

Migrate AttachmentPickerWithMenuItems to useOnyx

f6cc213

Migrate FloatingActionButtonAndPopover to useOnyx

c8f031f

Migrate IOURequestStepAmount to useOnyx

08ed668

Migrate IOURequestStepDistance to useOnyx

aef5b90

Migrate IOURequestStepParticipants to useOnyx

ff81d54

Migrate IOURequestStepScan to useOnyx

9a807a3

Migrate ReportWelcomeText to useOnyx

e078baf

grgia self-requested a review September 23, 2024 10:30

fabioh8010 mentioned this pull request Sep 23, 2024

[A/B Testing - Create Expense] Implement Create Expense Flow under hidden Beta #49007

Merged

50 tasks

fabioh8010 changed the title ~~[WIP] Migrate touched components #49007 from to useOnyx~~ [WIP] [A/B Testing][ESLint Clean Up] Use useOnyx cases for files in combinedTrackSubmit Sep 23, 2024

fabioh8010 changed the title ~~[WIP] [A/B Testing][ESLint Clean Up] Use useOnyx cases for files in combinedTrackSubmit~~ [WIP HOLD #49007] [A/B Testing][ESLint Clean Up] Use useOnyx cases for files in combinedTrackSubmit Sep 25, 2024

fabioh8010 changed the title ~~[WIP HOLD #49007] [A/B Testing][ESLint Clean Up] Use useOnyx cases for files in combinedTrackSubmit~~ [WIP HOLD PR #49007] [A/B Testing][ESLint Clean Up] Use useOnyx cases for files in combinedTrackSubmit Sep 25, 2024

fabioh8010 mentioned this pull request Sep 26, 2024

[$250] [A/B Testing][ESLint Clean Up ] Use useOnyx cases for files in combinedTrackSubmit #49593

Closed

grgia requested a review from shubham1206agra October 1, 2024 13:57

fabioh8010 added 2 commits October 3, 2024 09:08

Merge branch 'main' into feature/combined-expense-flow-48787-withOnyx…

e1c4a1f

…-migration

Minor adjustment

277fea0

fabioh8010 changed the title ~~[WIP HOLD PR #49007] [A/B Testing][ESLint Clean Up] Use useOnyx cases for files in combinedTrackSubmit~~ [A/B Testing][ESLint Clean Up] Use useOnyx cases for files in combinedTrackSubmit Oct 3, 2024

fedirjh mentioned this pull request Oct 3, 2024

[CP] don't show just track it option unless coming from CREATE flow #50068

Merged

52 tasks

Merge remote-tracking branch 'origin/main' into feature/combined-expe…

63c861c

…nse-flow-48787-withOnyx-migration

fabioh8010 marked this pull request as ready for review October 3, 2024 11:34

fabioh8010 requested a review from a team as a code owner October 3, 2024 11:34

melvin-bot bot requested review from MonilBhavsar and removed request for a team October 3, 2024 11:34

MonilBhavsar previously approved these changes Oct 4, 2024

View reviewed changes

Merge branch 'main' into feature/combined-expense-flow-48787-withOnyx…

522edb1

…-migration

Merge branch 'main' into feature/combined-expense-flow-48787-withOnyx…

b735a36

…-migration

fabioh8010 mentioned this pull request Oct 18, 2024

Fix shouldDisplayTrackExpenseButton logic #50732

Merged

50 tasks

shubham1206agra approved these changes Oct 19, 2024

View reviewed changes

melvin-bot bot requested a review from grgia October 19, 2024 09:40

MonilBhavsar approved these changes Oct 21, 2024

View reviewed changes

grgia approved these changes Oct 21, 2024

View reviewed changes

grgia merged commit 030f67c into Expensify:main Oct 21, 2024
18 checks passed

melvin-bot bot added the Emergency label Oct 21, 2024

grgia removed the Emergency label Oct 21, 2024

github-actions bot mentioned this pull request Oct 22, 2024

Deploy Checklist: New Expensify 2024-10-22 #51219

Closed

74 tasks

This was referenced Oct 22, 2024

[CP Staging] Revert "[A/B Testing][ESLint Clean Up] Use useOnyx cases for files in combinedTrackSubmit" #51245

Merged

[HOLD for payment 2024-11-20] [$250] FAB - Track expense option is not present in FAB for Expensifail account #51242

Closed

IuliiaHerets mentioned this pull request Oct 22, 2024

[$250] Chat - Invalid welcome text when opening a conversation with a new user #51247

Closed

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[A/B Testing][ESLint Clean Up] Use useOnyx cases for files in combinedTrackSubmit #49592

[A/B Testing][ESLint Clean Up] Use useOnyx cases for files in combinedTrackSubmit #49592

fabioh8010 commented Sep 23, 2024 •

edited

Loading

grgia commented Sep 23, 2024

grgia commented Sep 23, 2024

fabioh8010 commented Sep 25, 2024

grgia commented Oct 1, 2024

melvin-bot bot commented Oct 3, 2024

MonilBhavsar left a comment

fabioh8010 commented Oct 11, 2024

fabioh8010 commented Oct 11, 2024

shubham1206agra commented Oct 11, 2024 •

edited

Loading

shubham1206agra commented Oct 14, 2024

fabioh8010 commented Oct 14, 2024

shubham1206agra commented Oct 16, 2024

fabioh8010 commented Oct 16, 2024

MonilBhavsar commented Oct 18, 2024

shubham1206agra commented Oct 19, 2024

MonilBhavsar left a comment

melvin-bot bot commented Oct 21, 2024

grgia commented Oct 21, 2024

OSBotify commented Oct 21, 2024

github-actions bot commented Oct 22, 2024

IuliiaHerets commented Oct 22, 2024

Julesssss commented Oct 22, 2024 •

edited

Loading

github-actions bot commented Oct 23, 2024

[A/B Testing][ESLint Clean Up] Use useOnyx cases for files in combinedTrackSubmit #49592

[A/B Testing][ESLint Clean Up] Use useOnyx cases for files in combinedTrackSubmit #49592

Conversation

fabioh8010 commented Sep 23, 2024 • edited Loading

Details

Fixed Issues

Tests

AccessOrNotFoundWrapper

AttachmentPickerWithMenuItems

FloatingActionButtonAndPopover

IOURequestStepAmount / IOURequestStepParticipants

IOURequestStepScan

IOURequestStepDistance

ReportWelcomeText

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

grgia commented Sep 23, 2024

grgia commented Sep 23, 2024

fabioh8010 commented Sep 25, 2024

grgia commented Oct 1, 2024

melvin-bot bot commented Oct 3, 2024

MonilBhavsar left a comment

Choose a reason for hiding this comment

fabioh8010 commented Oct 11, 2024

fabioh8010 commented Oct 11, 2024

shubham1206agra commented Oct 11, 2024 • edited Loading

shubham1206agra commented Oct 14, 2024

fabioh8010 commented Oct 14, 2024

shubham1206agra commented Oct 16, 2024

fabioh8010 commented Oct 16, 2024

MonilBhavsar commented Oct 18, 2024

shubham1206agra commented Oct 19, 2024

Reviewer Checklist

Screenshots/Videos

MonilBhavsar left a comment

Choose a reason for hiding this comment

melvin-bot bot commented Oct 21, 2024

grgia commented Oct 21, 2024

OSBotify commented Oct 21, 2024

github-actions bot commented Oct 22, 2024

IuliiaHerets commented Oct 22, 2024

Julesssss commented Oct 22, 2024 • edited Loading

github-actions bot commented Oct 23, 2024

fabioh8010 commented Sep 23, 2024 •

edited

Loading

shubham1206agra commented Oct 11, 2024 •

edited

Loading

Julesssss commented Oct 22, 2024 •

edited

Loading