Clear out old cached policies #5023
Conversation
| if (policyCollection[key]) { | ||
| return; | ||
| } | ||
|
|
There was a problem hiding this comment.
NAB: Is this space necessary?
There was a problem hiding this comment.
No, I just prefer to pad if statements with new lines so things are less visually compressed.
I believe that a page refresh is the only thing that would update that data (maybe a reconnection - but would have to look). We could create a new issue to see if that's a priority (and sync things up with web sockets, polling, refetch when visiting the settings page or something else), but it feels tangential to the issue reported by @MitchExpensify. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by @joelbettner in version: 1.0.96-1 🚀
|
|
🚀 Deployed to production by @francoisl in version: 1.0.97-0 🚀
|
cc @deetergp
Details
I think maybe we did not implement this PR correctly probably because an assumption was made about
mergeCollection()that would clear out old cached values. I will have to look into that at some point. But I'm not sure if it works that way.Fixed Issues
$ https://github.com/Expensify/Expensify/issues/174831
Tests / QA Steps
Tested On
Note: I am skipping testing on all platforms in the interest of saving time since I can't think of any reason why this code would run differently on native / does not touch UI.
Screenshots
Web
Mobile Web
Desktop
iOS
Android