iOS - Hybrid app - Split - Cursor jumps in front of digit when deleting participant's amount #51306

WojtekBoman · 2024-10-23T07:31:27Z

Details

This PR fixes two issues with the jumping cursor on iOS:

jump to the beginning of the number (for long numbers).

This issue was caused by reading an old value from input in onSelectionChange. onSelectionChange uses e.nativeEvent.selection and formattedAmount to determine the cursor position. When we update amount on iOS, the formattedAmount value read in onSelectionChange is the previous value and not the value given in the setNewAmount function. To fix this, amountRef has been added to read the updated value. Thanks to this, the cursor position is now read correctly.

Before fix:

Screen.Recording.2024-10-24.at.11.11.51.mov

After:

Screen.Recording.2024-10-24.at.09.11.49.mov

For large numbers, formatting is important, removing one number can reduce the number in the input by many characters. In this case, if we specify the cursor position on an old number with more characters, we point to an index that does not exist, this causes the cursor to jump to the beginning.

double cursor jump when deleting numbers.

This issue has been fixed by changing the value of shouldIgnoreSelectionWhenUpdatedManually to true on iOS. This prevents the selection from being updated twice, which was the source of the problem.

Before fix:

Screen.Recording.2024-10-24.at.11.12.15.mov

After:

Screen.Recording.2024-10-24.at.09.12.14.mov

Fixed Issues

$ #50886
PROPOSAL:

Tests

Verify that no errors appear in the JS console

Open the app and log in
Navigate to the group chat
Tap + > Split expense
Enter the amount and proceed to the confirmation page
Delete the participant's amount by tapping the delete key
Select the other participant's amount by double tapping and remove it
Verify that the cursor does not jump during deletion

Offline tests

QA Steps

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2024-10-24.at.10.24.53.mov

Android: mWeb Chrome

Screen.Recording.2024-10-24.at.10.38.38.mov

iOS: Native

Screen.Recording.2024-10-24.at.09.10.36.mov

iOS: mWeb Safari

Screen.Recording.2024-10-24.at.09.51.54.mov

MacOS: Chrome / Safari

Screen.Recording.2024-10-24.at.10.48.40.mov

MacOS: Desktop

Screen.Recording.2024-10-24.at.09.55.40.mp4

melvin-bot · 2024-10-24T09:50:23Z

@rayane-djouah Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

rayane-d · 2024-10-27T18:43:45Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

android_native.mp4

Android: mWeb Chrome

android_mweb_chrome.mp4

iOS: Native

Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2024-10-30.at.13.16.52.mp4

iOS: mWeb Safari

Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2024-10-30.at.12.26.51.mp4

MacOS: Chrome / Safari

Screen.Recording.2024-10-30.at.12.21.58.PM.mov

MacOS: Desktop

Screen.Recording.2024-10-30.at.12.22.27.PM.mov

rayane-d · 2024-10-30T09:54:56Z

@WojtekBoman BUG: On the Android native app, when splitting 9000 with 4 users, the confirmation page incorrectly displays the participant amounts as 0.

android_native.mp4

rayane-d · 2024-10-30T09:57:24Z

This ^ bug is also reproducible on the main branch

rayane-d · 2024-10-30T11:33:24Z

@WojtekBoman BUG: On the iOS native app, when splitting 5000 with 4 users, I can't edit the participant amounts on the confirmation page.

Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2024-10-30.at.12.31.41.mp4

rayane-d · 2024-10-30T11:36:10Z

This ^ bug is also reproducible on the main branch

rayane-d

LGTM and tests well 👍

mountiny

Thanks for the fix and a review from @rayane-djouah !

OSBotify · 2024-10-30T12:32:22Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2024-10-31T11:41:09Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.0.56-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2024-11-04T14:13:53Z

🚀 Deployed to production by https://github.com/Julesssss in version: 9.0.56-9 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	skipped 🚫
🍎🔄 iOS HybridApp 🍎🔄	skipped 🚫

WojtekBoman added 3 commits October 22, 2024 15:20

Read amount from ref in onSelectionChange in MoneyRequestAmountInput

69704c1

Merge branch 'main' into fix/selection-on-ios

de96e63

Add comment to onSelectionChange in MoneyRequestAmountInput

47969e5

WojtekBoman marked this pull request as ready for review October 24, 2024 09:50

WojtekBoman requested a review from a team as a code owner October 24, 2024 09:50

melvin-bot bot requested review from rayane-d and removed request for a team October 24, 2024 09:50

Christinadobrzyn mentioned this pull request Oct 29, 2024

[HOLD for payment 2024-11-11] iOS - Hybrid app - Split - Cursor jumps in front of digit when deleting participant's amount #50886

Closed

8 tasks

mountiny self-requested a review October 30, 2024 08:28

mountiny assigned WojtekBoman Oct 30, 2024

rayane-d approved these changes Oct 30, 2024

View reviewed changes

mountiny approved these changes Oct 30, 2024

View reviewed changes

mountiny merged commit ffc8c3d into Expensify:main Oct 30, 2024
17 checks passed

github-actions bot mentioned this pull request Oct 31, 2024

Deploy Checklist: New Expensify 2024-10-31 #51778

Closed

rayane-d mentioned this pull request Nov 6, 2024

Reusable and stylable money request amount input #40390

Merged

50 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

iOS - Hybrid app - Split - Cursor jumps in front of digit when deleting participant's amount #51306

iOS - Hybrid app - Split - Cursor jumps in front of digit when deleting participant's amount #51306

WojtekBoman commented Oct 23, 2024 •

edited

Loading

melvin-bot bot commented Oct 24, 2024

rayane-d commented Oct 27, 2024 •

edited

Loading

rayane-d commented Oct 30, 2024

rayane-d commented Oct 30, 2024

rayane-d commented Oct 30, 2024 •

edited

Loading

rayane-d commented Oct 30, 2024

rayane-d left a comment

mountiny left a comment

OSBotify commented Oct 30, 2024

github-actions bot commented Oct 31, 2024

github-actions bot commented Nov 4, 2024

iOS - Hybrid app - Split - Cursor jumps in front of digit when deleting participant's amount #51306

iOS - Hybrid app - Split - Cursor jumps in front of digit when deleting participant's amount #51306

Conversation

WojtekBoman commented Oct 23, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Oct 24, 2024

rayane-d commented Oct 27, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

rayane-d commented Oct 30, 2024

rayane-d commented Oct 30, 2024

rayane-d commented Oct 30, 2024 • edited Loading

rayane-d commented Oct 30, 2024

rayane-d left a comment

Choose a reason for hiding this comment

mountiny left a comment

Choose a reason for hiding this comment

OSBotify commented Oct 30, 2024

github-actions bot commented Oct 31, 2024

github-actions bot commented Nov 4, 2024

WojtekBoman commented Oct 23, 2024 •

edited

Loading

rayane-d commented Oct 27, 2024 •

edited

Loading

rayane-d commented Oct 30, 2024 •

edited

Loading