[Held requests] Hold button on expense preview appears only if open the expense first #51354

cdOut · 2024-10-23T17:48:52Z

Details

Changes the way we check whether to display the Hold/Unhold option in the context menu based on backend data of reportActions.

Fixed Issues

$ #47241
PROPOSAL:

Tests

Verify that no errors appear in the JS console

Offline tests

QA Steps

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

blazejkustra

High level the code looks good! Let me know once backend is ready se we can test if this works well 😄

blazejkustra · 2024-10-24T09:10:01Z

src/libs/ReportUtils.ts

+    } else {
+        const activeRoute = encodeURIComponent(Navigation.getActiveRouteWithoutParams());
+        Navigation.navigate(
+            // eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing


Is this comment necessary?

Good catch, it's not required here anymore.

blazejkustra · 2024-10-24T09:13:19Z

src/libs/ReportUtils.ts

@@ -3259,6 +3259,21 @@ const changeMoneyRequestHoldStatus = (reportAction: OnyxEntry<ReportAction>, bac
    }
 };

+const changePreviewHoldStatus = (isOnHold: boolean, transactionID: string, reportID: string): void => {


NAB: Let's use a named function

mountiny · 2024-11-14T12:25:26Z

This will be worked on by SWM in a new PR once this is a priority again

cdOut added 6 commits October 17, 2024 17:08

cleanup previous hold context code

8cbc87b

fix prettier and lint

27b0814

Merge branch 'main' into @cdOut/hold-context-unloaded

03d82d1

use Hold data instead of previous solution

52c40f2

fix prettier

4c64141

Merge branch 'main' into @cdOut/hold-context-unloaded

ca49fab

cdOut mentioned this pull request Oct 23, 2024

[Held requests] Hold button on expense preview appears only if open the expense first #47241

Open

6 tasks

blazejkustra approved these changes Oct 24, 2024

View reviewed changes

cdOut added 2 commits October 24, 2024 11:28

fix review issues

a921a23

Merge branch 'main' into @cdOut/hold-context-unloaded

d76919a

mountiny closed this Nov 14, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Held requests] Hold button on expense preview appears only if open the expense first #51354

[Held requests] Hold button on expense preview appears only if open the expense first #51354

cdOut commented Oct 23, 2024 •

edited

Loading

blazejkustra left a comment

blazejkustra Oct 24, 2024

cdOut Oct 24, 2024

blazejkustra Oct 24, 2024

mountiny commented Nov 14, 2024

[Held requests] Hold button on expense preview appears only if open the expense first #51354

[Held requests] Hold button on expense preview appears only if open the expense first #51354

Conversation

cdOut commented Oct 23, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

blazejkustra left a comment

Choose a reason for hiding this comment

blazejkustra Oct 24, 2024

Choose a reason for hiding this comment

cdOut Oct 24, 2024

Choose a reason for hiding this comment

blazejkustra Oct 24, 2024

Choose a reason for hiding this comment

mountiny commented Nov 14, 2024

cdOut commented Oct 23, 2024 •

edited

Loading