fix unread marking logic for mobile on visibility change #5155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jag96
reviewed
Sep 9, 2021
There was a problem hiding this comment.
@meetmangukiya are you able to set up an Android emulator and test Android that way?
|
@Jag96 I've not managed to get Android setup working on my m1 yet 😅 |
|
@meetmangukiya ok, I can test Android then. Can you update the description to have screenshots for web/desktop as well to confirm no regressions? Once that's updated I'll test/review |
Jag96
approved these changes
Sep 15, 2021
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
31 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
isVisiblenative implementation by using theAppState.currentStateto determine the state app is in.this.props.isDrawerOpen.Fixed Issues
$ #4855
Tests
QA Steps
Tested On
Screenshots
Web
Screen.Recording.2021-09-14.at.2.57.45.PM.mov
Screen.Recording.2021-09-14.at.2.58.43.PM.mov
Mobile Web
Not needed, native mobile bug only.
Desktop
Not needed, native mobile bug only.
iOS
Simulator.Screen.Recording.-.iPhone.12.-.2021-09-09.at.12.25.59.mp4
Android
Would need help testing this.