-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix categories imported are disabled #53246
fix categories imported are disabled #53246
Conversation
@getusha what is your eta on the review? |
Reviewer Checklist
Screenshots/VideosAndroid: NativeScreen.Recording.2024-12-04.at.5.31.46.in.the.afternoon.movAndroid: mWeb ChromeScreen.Recording.2024-12-04.at.5.19.53.in.the.afternoon.moviOS: NativeScreen.Recording.2024-12-04.at.6.55.28.in.the.evening.moviOS: mWeb SafariScreen.Recording.2024-12-04.at.6.22.50.in.the.evening.movMacOS: Chrome / SafariScreen.Recording.2024-12-04.at.4.39.55.in.the.afternoon.movMacOS: DesktopScreen.Recording.2024-12-04.at.6.13.00.in.the.evening.mov |
@huult do you think we can add a unit test for this? |
@getusha This only transforms data to a string and doesn’t involve complex logic or state changes. const data = [
"hello",
42,
123456789012345n,
true,
undefined,
Symbol('id'),
null
];
const stringified = data.map(item => String(item)); We can test all data types like boolean and number or ... converting to string without any errors. Therefore, a unit test might not be necessary. Let me know if you think otherwise! |
Sounds fair, @mountiny wdyt? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@huult I think ti would be great to actually set up an unit tests that will test the full readFile
flow to ensure that method works. Can you look into that please?
…s-imported-are-disabled
@mountiny I am writing the unit test now |
@mountiny I encountered some issues while setting up ImportSpreadSheetTest, so I will continue tomorrow. I will ping you when it's done. |
…s-imported-are-disabled
@mountiny Can we skip the unit tests for this pull request? I tried, but it's more complex than I expected |
Alright, thanks for looking into this |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Performance Comparison Report 📊Significant Changes To Duration
Show details
Meaningless Changes To DurationShow entries
Show details
|
@Expensify/mobile-deployers 📣 Please look into this performance regression as it's a deploy blocker. |
🚀 Deployed to staging by https://github.com/mountiny in version: 9.0.73-0 🚀
|
🚀 Deployed to production by https://github.com/luacmartins in version: 9.0.73-8 🚀
|
Details
Fixed Issues
$ #52466
PROPOSAL: #52466 (comment)
Tests
Same QA step
Offline tests
QA Steps
Bug6663366_1731473053062.Applausecard_s_Workspace_categories (1).csv
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Screen.Recording.2024-11-28.at.21.37.29.mp4
Android: mWeb Chrome
Screen.Recording.2024-11-28.at.21.38.26.mp4
iOS: Native
Screen.Recording.2024-11-28.at.21.45.07.mp4
iOS: mWeb Safari
Screen.Recording.2024-11-28.at.21.45.52.mp4
MacOS: Chrome / Safari
Screen.Recording.2024-11-28.at.21.46.26.mp4
MacOS: Desktop
Screen.Recording.2024-11-28.at.21.48.15.mp4