Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Close keyboard on save for VBA forms #5325

Merged
merged 1 commit into from
Sep 17, 2021
Merged

Close keyboard on save for VBA forms #5325

merged 1 commit into from
Sep 17, 2021

Conversation

Jag96
Copy link
Contributor

@Jag96 Jag96 commented Sep 17, 2021

Details

Fixed Issues

Fixes bug in slack

Tests/QA

  1. Create a new workspace and go through the Create flow
  2. On iOS and Android, confirm that when hitting the Save and Continue button, the keyboard dismisses and the form is submitted instead of just the keyboard being dismissed.
  3. Confirm that on web/desktop submitting the forms still works.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

@Jag96 Jag96 self-assigned this Sep 17, 2021
@Jag96 Jag96 requested a review from a team as a code owner September 17, 2021 18:21
@MelvinBot MelvinBot requested review from joelbettner and removed request for a team September 17, 2021 18:22
@joelbettner joelbettner merged commit f20deb8 into main Sep 17, 2021
@joelbettner joelbettner deleted the joe-close-keyboard-on-save branch September 17, 2021 19:08
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify OSBotify mentioned this pull request Sep 20, 2021
Closed
31 tasks
@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @joelbettner in version: 1.0.99-5 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @Jag96 in version: 1.1.0-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joelbettner joelbettner joelbettner approved these changes

Assignees

@Jag96 Jag96

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Jag96 @OSBotify @joelbettner