-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase global create modal delay to 1500ms #5369
Conversation
# Conflicts: # src/pages/home/sidebar/SidebarScreen.js
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and tests well.
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Should we CP this? When I created this the checklist was still unlocked. |
Ah good point, yeah I can CP manually |
Increase global create modal delay to 1500ms (cherry picked from commit 112bad2)
🚀 Cherry-picked to staging by @Jag96 in version: 1.1.0-1 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
Details
Hopefully temporary workaround until #5296 is resolved.
Fixed Issues
$ #5303
Tests / QA Steps
Dev-only tip: Emulate this by setting the following NVP:
Tested On
Screenshots
Web
Screen.Recording.2021-09-20.at.2.38.45.PM.mov
Mobile Web
Screen.Recording.2021-09-20.at.2.43.13.PM.mov
Desktop
Screen.Recording.2021-09-20.at.2.46.20.PM.mov
iOS
Screen.Recording.2021-09-20.at.2.15.37.PM.mov
Android