Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweaks to the expense flow #53760

Conversation

JKobrynski
Copy link
Contributor

@JKobrynski JKobrynski commented Dec 9, 2024

Explanation of Change

Implement the requirements specified in this comment

FYI

Screen title changes that were specified in the above comment were already implemented thus they are not included in this PR.

Fixed Issues

$ #52981
PROPOSAL: N/A

Tests

  1. Log into the app
  2. Click on the + button
  3. Select the Create expense option
  4. Choose the Manual expense
  5. Provide an expense value
  6. Navigate to the next step
  7. Make sure the Just track it (don't submit it) option row is not visible
  8. Verify if there is a Workspace and Personal section
  9. Test if you can submit an expenses to workspaces, recents, contacts and to yourself
  10. Verify the button on the Confirm details screen says "Create amount expense"
  • Verify that no errors appear in the JS console

Offline tests

Same as Tests section above

QA Steps

Same as Tests section above

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
android-compressed.webm
Android: mWeb Chrome
chrome-compressed.webm
iOS: Native
ios-compressed.mp4
iOS: mWeb Safari
safari-compressed.mp4
MacOS: Chrome / Safari
MacOS: Desktop

Sorry, something went wrong.

@JKobrynski JKobrynski marked this pull request as ready for review December 10, 2024 16:12
@JKobrynski JKobrynski requested a review from a team as a code owner December 10, 2024 16:12
@melvin-bot melvin-bot bot requested review from suneox and removed request for a team December 10, 2024 16:12
Copy link

melvin-bot bot commented Dec 10, 2024

@suneox Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Copy link
Contributor

🚧 @trjExpensify has triggered a test build. You can view the workflow run here.

This comment has been minimized.

…aks-to-create-expense-flow
@shawnborton
Copy link
Contributor

@trjExpensify is there a separate PR that just gets rid of the Track & Submit options and replaces it with the Create flow? Wasn't sure if we were doing that here or elsewhere. cc @anmurali for thoughts too

@shawnborton
Copy link
Contributor

Idea for the future: whenever we have the "Default" badge for the default workspace in the Workspaces list from Settings, we should consider adding it here too on the right side of the workspace row?
CleanShot 2024-12-11 at 14 05 22@2x

@trjExpensify
Copy link
Contributor

That's a neat idea!

@trjExpensify
Copy link
Contributor

@trjExpensify is there a separate PR that just gets rid of the Track & Submit options and replaces it with the Create flow? Wasn't sure if we were doing that here or elsewhere. cc @anmurali for thoughts too

Separate PR & issue here: #53952

…aks-to-create-expense-flow
@trjExpensify
Copy link
Contributor

@JKobrynski is this ready for a re-review?

@JKobrynski
Copy link
Contributor Author

@trjExpensify not yet! Should be ready tomorrow

…aks-to-create-expense-flow
@JKobrynski
Copy link
Contributor Author

@trjExpensify I created a orderWorkspaceOptions method that puts the default workspace on top of the list and added it to orderOptions, it should be fine now.

Copy link
Contributor

@grgia grgia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me, I'm triggering a final test build now to do a final QA

Copy link
Contributor

github-actions bot commented Jan 2, 2025

🚧 @grgia has triggered a test build. You can view the workflow run here.

Copy link
Contributor

github-actions bot commented Jan 2, 2025

Copy link
Contributor

@grgia grgia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and tests well! 🎉

@grgia
Copy link
Contributor

grgia commented Jan 3, 2025

@mountiny could you rereview? I'm blocked from merging 🙏

Copy link
Contributor

@mountiny mountiny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets try this out, thank you!

@mountiny mountiny merged commit b23c478 into Expensify:main Jan 3, 2025
19 checks passed
@OSBotify
Copy link
Contributor

OSBotify commented Jan 3, 2025

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

Copy link
Contributor

github-actions bot commented Jan 6, 2025

🚀 Deployed to staging by https://github.com/mountiny in version: 9.0.81-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅
🤖🔄 android HybridApp 🤖🔄 failure ❌
🍎🔄 iOS HybridApp 🍎🔄 success ✅

grgia added a commit that referenced this pull request Jan 7, 2025
…feat/tweaks-to-create-expense-flow"

This reverts commit b23c478, reversing
changes made to 81186aa.
grgia added a commit that referenced this pull request Jan 7, 2025
…feat/tweaks-to-create-expense-flow"

This reverts commit b23c478, reversing
changes made to 81186aa.
grgia added a commit that referenced this pull request Jan 7, 2025
[CP Staging] Revert "Merge pull request #53760 from callstack-internal/JKobrynski/…
OSBotify pushed a commit that referenced this pull request Jan 7, 2025
[CP Staging] Revert "Merge pull request #53760 from callstack-internal/JKobrynski/…

(cherry picked from commit 19801f2)

(CP triggered by grgia)
Copy link
Contributor

github-actions bot commented Jan 8, 2025

🚀 Deployed to production by https://github.com/puneetlath in version: 9.0.81-6 🚀

platform result
🤖 android 🤖 true ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅
🤖🔄 android HybridApp 🤖🔄 failure ❌
🍎🔄 iOS HybridApp 🍎🔄 success ✅

Copy link
Contributor

github-actions bot commented Jan 8, 2025

🚀 Deployed to staging by https://github.com/mountiny in version: 9.0.82-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅
🤖🔄 android HybridApp 🤖🔄 failure ❌
🍎🔄 iOS HybridApp 🍎🔄 failure ❌

1 similar comment
Copy link
Contributor

github-actions bot commented Jan 8, 2025

🚀 Deployed to staging by https://github.com/mountiny in version: 9.0.82-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅
🤖🔄 android HybridApp 🤖🔄 failure ❌
🍎🔄 iOS HybridApp 🍎🔄 failure ❌

@izarutskaya
Copy link

@JKobrynski QA faund issue when validation this PR - issue #54953

Bug6708738_1736309224876.PR_53760_Desktop.mp4

@mountiny
Copy link
Contributor

mountiny commented Jan 8, 2025

@izarutskaya @grgia I think this was reverted, right?

@trjExpensify
Copy link
Contributor

@JKobrynski can we get a status update on the new PR including the fixes it was reverted for, please? Thanks!

@JKobrynski JKobrynski mentioned this pull request Jan 9, 2025
50 tasks
Copy link
Contributor

🚀 Deployed to production by https://github.com/thienlnam in version: 9.0.82-12 🚀

platform result
🤖 android 🤖 true ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅
🤖🔄 android HybridApp 🤖🔄 failure ❌
🍎🔄 iOS HybridApp 🍎🔄 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants