-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tweaks to the expense flow #53760
Tweaks to the expense flow #53760
Conversation
🚧 @trjExpensify has triggered a test build. You can view the workflow run here. |
This comment has been minimized.
This comment has been minimized.
…aks-to-create-expense-flow
@trjExpensify is there a separate PR that just gets rid of the Track & Submit options and replaces it with the Create flow? Wasn't sure if we were doing that here or elsewhere. cc @anmurali for thoughts too |
That's a neat idea! |
Separate PR & issue here: #53952 |
…aks-to-create-expense-flow
@JKobrynski is this ready for a re-review? |
@trjExpensify not yet! Should be ready tomorrow |
…aks-to-create-expense-flow
@trjExpensify I created a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good to me, I'm triggering a final test build now to do a final QA
🚧 @grgia has triggered a test build. You can view the workflow run here. |
🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and tests well! 🎉
@mountiny could you rereview? I'm blocked from merging 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets try this out, thank you!
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/mountiny in version: 9.0.81-0 🚀
|
[CP Staging] Revert "Merge pull request #53760 from callstack-internal/JKobrynski/…
🚀 Deployed to production by https://github.com/puneetlath in version: 9.0.81-6 🚀
|
🚀 Deployed to staging by https://github.com/mountiny in version: 9.0.82-0 🚀
|
1 similar comment
🚀 Deployed to staging by https://github.com/mountiny in version: 9.0.82-0 🚀
|
@JKobrynski QA faund issue when validation this PR - issue #54953 Bug6708738_1736309224876.PR_53760_Desktop.mp4 |
@izarutskaya @grgia I think this was reverted, right? |
@JKobrynski can we get a status update on the new PR including the fixes it was reverted for, please? Thanks! |
🚀 Deployed to production by https://github.com/thienlnam in version: 9.0.82-12 🚀
|
Explanation of Change
Implement the requirements specified in this comment
FYI
Screen title changes that were specified in the above comment were already implemented thus they are not included in this PR.
Fixed Issues
$ #52981
PROPOSAL: N/A
Tests
Offline tests
Same as Tests section above
QA Steps
Same as Tests section above
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
android-compressed.webm
Android: mWeb Chrome
chrome-compressed.webm
iOS: Native
ios-compressed.mp4
iOS: mWeb Safari
safari-compressed.mp4
MacOS: Chrome / Safari
MacOS: Desktop