Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow uploading drivers license like we do on OldDot #5391

Merged
merged 1 commit into from
Sep 22, 2021

Conversation

marcaaron
Copy link
Contributor

@marcaaron marcaaron commented Sep 21, 2021

Details

These changes only affect web. I noticed that we do not allow uploading a driver's license on NewDot but do on OldDot. When selecting Identity card option Onfido will not allow me to upload by state driver's license. This PR fixes that by enabling the specific option for driver's licenses.

2021-09-21_06-50-15

2021-09-21_06-49-43

Fixed Issues

$ #5395

Tests

  1. Go through VBA flow for a Verifying bank account
  2. When you reach the Onfido flow verify there is an option for a driver's license
  3. Upload a US Driver's License
  4. Verify you are able to do so without issue and pass the Onfido step

QA Steps

Internal QA

Tested On

  • Web
  • Mobile Web
  • Desktop
  • N/A iOS
  • N/A Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

@marcaaron marcaaron self-assigned this Sep 21, 2021
@marcaaron marcaaron marked this pull request as ready for review September 21, 2021 19:13
@marcaaron marcaaron requested a review from a team as a code owner September 21, 2021 19:13
@MelvinBot MelvinBot requested review from AndrewGable and removed request for a team September 21, 2021 19:14
@AndrewGable AndrewGable merged commit 1381685 into main Sep 22, 2021
@AndrewGable AndrewGable deleted the marcaaron-allowOnfidoDriversLicense branch September 22, 2021 20:33
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @AndrewGable in version: 1.1.1-9 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@isagoico
Copy link

@marcaaron can you let us know when this is QAd so we can check it off the list?

@marcaaron
Copy link
Contributor Author

Worked great for me.

@MitchExpensify
Copy link
Contributor

Tested too - works great

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @timszot in version: 1.1.2-7 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants