[HybridApp] Fix Not found page on shortcuts
#53954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚧 @Julesssss has triggered a test hybrid app build. You can view the workflow run here. |
This comment has been minimized.
This comment has been minimized.
war-in
changed the title
Not found page on shortcutsNot found page on shortcuts
melvin-bot
bot
requested review from
marcochavezf
and removed request for
a team
|
@marcochavezf Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
This PR requires |
|
Conflicts |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
|
# Conflicts: # Mobile-Expensify # scripts/run-build.sh
|
🚧 @Julesssss has triggered a test build. You can view the workflow run here. |
|
🚧 @Julesssss has triggered a test hybrid app build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
|
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
|
# Conflicts: # Mobile-Expensify # scripts/run-build.sh
# Conflicts: # Mobile-Expensify
|
🚧 @marcochavezf has triggered a test build. You can view the workflow run here. |
|
No prob, pulled the PR code and started the build will update soon with test results |
|
works well for IOS now but android still has same problem as in #53954 (comment) Screen.Recording.2025-01-17.at.2.18.48.AM.mov |
|
🚧 @mountiny has triggered a test hybrid app build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
|
|
Hello @ishpaul777 
It works like on the recordings: NDshortcuts-ND.movODshortcuts-OD.mov |
|
tried again it worked well for me android as well Screen.Recording.2025-01-20.at.6.12.40.PM.mov |
ishpaul777
approved these changes
Jan 20, 2025
|
🎯 @ishpaul777, thanks for reviewing and testing this PR! 🎉 An E/App issue has been created to issue payment here: #55476. |
Hmm, it might be 🤔 I'd not bock on this issue because working shortcuts are more important but we should investigate it more 👍 |
marcochavezf
approved these changes
Jan 21, 2025
|
All yours @Julesssss |
Julesssss
approved these changes
Jan 21, 2025
|
Okay nice. So I will merge both App and Mobile-Expensify. In theory, both will then work with the next checklist (when the App changes get placed and the Mobile-Expensify commit is bumped). |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
github-actions
bot
added
the
DeployBlockerCash
Performance Comparison Report 📊Significant Changes To Duration
Show details
Meaningless Changes To DurationShow entries
Show details
|
|
@Expensify/mobile-deployers 📣 Please look into this performance regression as it's a deploy blocker. |
|
🚀 Deployed to staging by https://github.com/Julesssss in version: 9.0.89-0 🚀
|
|
🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.0.89-8 🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation of Change
This PR fixes the
Hmm it's not there...page when clicking on the static shortcuts.Related OD PR: https://github.com/Expensify/Mobile-Expensify/pull/13327
Fixed Issues
$ #55585
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop