Avoid logging AuthToken from transition links #5425
Conversation
|
|
|
Tested this locally and it works: |
|
|
||
| // Don't log the route transitions from OldDot because they contain authTokens | ||
| if (path.includes('/transition/')) { | ||
| Log.info('Navigating from transition link from OldDot using short lived authToken'); |
There was a problem hiding this comment.
Actually I don't think we need to log this immediately though so we can add a false like we are doing in the other call?
There was a problem hiding this comment.
Actually wait theres no need, it's false by default: https://github.com/Expensify/expensify-common/blob/master/lib/Logger.jsx#L82
Avoid logging AuthToken from transition links (cherry picked from commit 64e2140)
|
🚀 Cherry-picked to staging by @TomatoToaster in version: 1.1.1-2 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
|
My bad on the testing steps, it's not actually going to be on the dev console in staging, but in the real logs. @MitchExpensify tested it and the logs for the request being correctly logged are right here: https://www.expensify.com/_devportal/tools/logSearch/#sort=asc&size=2000&query=blob%3A%20%22Navigating%20from%22%20AND%20email%3A%22mitch%40frankchu.xyz%22%20AND%20timestamp%3A%5B2021-09-23T00%3A00%20TO%202021-09-24T23%3A59%5D So i can say this passed QA on Staging 👍🏾 |
|
🚀 Deployed to staging by @TomatoToaster in version: 1.1.1-9 🚀
|
CC: @marcaaron
Details
Fixed Issues
Follow up to a problem identified here: #5396 (comment)
Tests
Same as Web QA done locally
QA Steps
Exact same as this PR: #5396
After you've navigated to NewDot successfully, open up the JS console and search for the log line:
Navigating from transition link from OldDot using short lived authTokenand verify you don't see any huge authToken in the logs like here: #5396 (comment)Tested On
Screenshots
N/A