Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: line height issues of button #5464

Merged
merged 1 commit into from
Sep 23, 2021
Merged

Fix: line height issues of button #5464

merged 1 commit into from
Sep 23, 2021

Conversation

parasharrajat
Copy link
Member

@parasharrajat parasharrajat commented Sep 23, 2021 •
edited
Loading

Details

  1. Allow the Text component to override the default line-height.
  2. Removed the Line-height from Button Text to vertically center any size button.

Fixed Issues

$ #5333

Tests | QA Steps

  1. Create a workspace.
  2. Enter Expensify Card tab.
  3. See the "Get Started" and "Help" buttons are properly aligned on the vertical axis.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web | Desktop

image

Mobile Web

Screenshot 2021-09-24 00:24:09

iOS

Android

Screenshot 2021-09-24 00:12:25

@parasharrajat parasharrajat requested a review from a team as a code owner September 23, 2021 18:54
@MelvinBot MelvinBot requested review from chiragsalian and removed request for a team September 23, 2021 18:55
chiragsalian
chiragsalian approved these changes Sep 23, 2021
View reviewed changes
Copy link
Contributor

@chiragsalian chiragsalian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chiragsalian chiragsalian merged commit 14238c2 into Expensify:main Sep 23, 2021
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify OSBotify mentioned this pull request Sep 23, 2021
Closed
27 tasks
@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @chiragsalian in version: 1.1.1-9 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@isagoico
Copy link

@parasharrajat @chiragsalian is it ok if we test this with the "Manage Cards" button?

@parasharrajat
Copy link
Member Author

Yeah @isagoico with any button in the app.

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @timszot in version: 1.1.2-7 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chiragsalian chiragsalian chiragsalian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@parasharrajat @OSBotify @isagoico @chiragsalian