Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix - Expense - In offline, on creating second split expense user not scrolled down to new expense. #54791

Merged
merged 4 commits into from
Feb 5, 2025
Merged

Fix - Expense - In offline, on creating second split expense user not scrolled down to new expense. #54791

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5c61824
use spreading on onyx data
FitseTLT Jan 3, 2025
1185ea2
Merge branch 'main' into fix-split-request-scroll-to-bottom-not-working
FitseTLT Jan 27, 2025
08756f8
minor fix
FitseTLT Jan 27, 2025
fbb1cba
Merge branch 'main' into fix-split-request-scroll-to-bottom-not-working
FitseTLT Jan 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/libs/actions/IOU.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4789,7 +4789,8 @@ function getOrCreateOptimisticSplitChatReport(existingSplitChatReportID: string,
const existingChatReportID = existingSplitChatReportID || participants.at(0)?.reportID;

// Check if the report is available locally if we do have one
let existingSplitChatReport = existingChatReportID ? allReports?.[`${ONYXKEYS.COLLECTION.REPORT}${existingChatReportID}`] : null;
const existingSplitChatOnyxData = allReports?.[`${ONYXKEYS.COLLECTION.REPORT}${existingChatReportID}`];
let existingSplitChatReport = existingChatReportID && existingSplitChatOnyxData ? {...existingSplitChatOnyxData} : undefined;

const allParticipantsAccountIDs = [...participantAccountIDs, currentUserAccountID];
if (!existingSplitChatReport) {
Expand Down