Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moves all free plan beta checks to use free plan soft launch beta #5485

Merged
merged 1 commit into from
Sep 24, 2021

Conversation

iwiznia
Copy link
Contributor

@iwiznia iwiznia commented Sep 24, 2021

Needs https://github.com/Expensify/Web-Expensify/pull/32022

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/178653

Tests

  • Does not apply to QA: force permissions.canUseFreePlan to return false and permissions.canUseFreePlanSoftLaunch to return true
  • On oldDot, on a new account on a new domain, go to Settings > Policies > Group and check you can see the free plan option, click it and you should be taken to newDot workflow page, close that modal
  • On oldDot delete the newly created policy
  • Refresh newDot
  • Check the big plus button has the option to create a new workspace and that it works

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

@iwiznia iwiznia requested a review from a team as a code owner September 24, 2021 11:30
@iwiznia iwiznia self-assigned this Sep 24, 2021
@MelvinBot MelvinBot requested review from deetergp and removed request for a team September 24, 2021 11:31
@github-actions
Copy link
Contributor

⚠️ ⚠️ Heads up! This pull request has the CP Staging label. ⚠️ ⚠️
Merging it will cause it to be immediately deployed to staging, even if the open StagingDeployCash deploy checklist is locked.

@iwiznia iwiznia changed the title [HOLD web] Moves all free plan beta checks to use free plan soft launch beta Moves all free plan beta checks to use free plan soft launch beta Sep 24, 2021
@Julesssss
Copy link
Contributor

Confirmed on Web.

@iwiznia iwiznia merged commit a75a194 into main Sep 24, 2021
@iwiznia iwiznia deleted the ionatan_addbeta_freeplansoftlaunch branch September 24, 2021 12:56
github-actions bot pushed a commit that referenced this pull request Sep 24, 2021
@OSBotify
Copy link
Contributor

🚀 Cherry-picked to staging by @AndrewGable in version: 1.1.2-1 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @timszot in version: 1.1.2-7 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @iwiznia in version: 1.1.2-9 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @timszot in version: 1.1.3-1 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants