Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HybridApp setup step to prevent build issues #54882

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

Julesssss
Copy link
Contributor

Explanation of Change

Simply adds a hidden build step that will cause problems for all new HybridApp repo clones. This is a short-term fix for #54877, which will automate this step.

Fixed Issues

$ #54877

N/A

@Julesssss Julesssss self-assigned this Jan 7, 2025
@Julesssss Julesssss marked this pull request as ready for review January 7, 2025 16:23
@Julesssss Julesssss requested a review from a team as a code owner January 7, 2025 16:23
@melvin-bot melvin-bot bot requested a review from rushatgabhane January 7, 2025 16:23
Copy link

melvin-bot bot commented Jan 7, 2025

@rushatgabhane Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot bot removed the request for review from a team January 7, 2025 16:23
@Julesssss Julesssss removed the request for review from rushatgabhane January 7, 2025 16:23
@Julesssss
Copy link
Contributor Author

No C+ review required here.

Copy link
Contributor

@NikkiWines NikkiWines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$approved$

@Julesssss
Copy link
Contributor Author

Merging without full checklist

@Julesssss Julesssss merged commit cd43345 into main Jan 7, 2025
5 of 8 checks passed
@Julesssss Julesssss deleted the jules-addHybridAppBuildStep branch January 7, 2025 16:26
Copy link

melvin-bot bot commented Jan 7, 2025

@Julesssss looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@melvin-bot melvin-bot bot added the Emergency label Jan 7, 2025
@Julesssss
Copy link
Contributor Author

Merging without full checklist

^^^

@OSBotify
Copy link
Contributor

OSBotify commented Jan 7, 2025

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

Copy link
Contributor

github-actions bot commented Jan 8, 2025

🚀 Deployed to staging by https://github.com/Julesssss in version: 9.0.82-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅
🤖🔄 android HybridApp 🤖🔄 failure ❌
🍎🔄 iOS HybridApp 🍎🔄 failure ❌

1 similar comment
Copy link
Contributor

github-actions bot commented Jan 8, 2025

🚀 Deployed to staging by https://github.com/Julesssss in version: 9.0.82-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅
🤖🔄 android HybridApp 🤖🔄 failure ❌
🍎🔄 iOS HybridApp 🍎🔄 failure ❌

Copy link
Contributor

🚀 Deployed to production by https://github.com/thienlnam in version: 9.0.82-12 🚀

platform result
🤖 android 🤖 true ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅
🤖🔄 android HybridApp 🤖🔄 failure ❌
🍎🔄 iOS HybridApp 🍎🔄 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants