Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix WorkspaceNew in linkingConfig since it's a screen not a modal #5501

Merged
merged 1 commit into from
Sep 24, 2021

Conversation

marcaaron
Copy link
Contributor

@marcaaron marcaaron commented Sep 24, 2021

Details

I am not sure if this will fix the linked issue but we can test it on staging to see.

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/178594

Tests / QA Steps

  1. Sign out of NewDot
  2. Sign up for a new account in OldDot on a mobile web (small width on Chrome or iPhone user agent in safari or iOS simulator)
  3. Tap the first link
  4. Verify you are brought to the workspace page

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

Copy link
Contributor

@luacmartins luacmartins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 🤞

@marcaaron marcaaron self-assigned this Sep 24, 2021
@marcaaron marcaaron marked this pull request as ready for review September 24, 2021 18:04
@marcaaron marcaaron requested a review from a team as a code owner September 24, 2021 18:04
@MelvinBot MelvinBot requested review from aldo-expensify and removed request for a team September 24, 2021 18:04
@github-actions
Copy link
Contributor

⚠️ ⚠️ Heads up! This pull request has the CP Staging label. ⚠️ ⚠️
Merging it will cause it to be immediately deployed to staging, even if the open StagingDeployCash deploy checklist is locked.

@marcaaron marcaaron merged commit 14e3a95 into main Sep 24, 2021
@marcaaron marcaaron deleted the marcaaron-fixWorkspaceRoutee branch September 24, 2021 18:46
github-actions bot pushed a commit that referenced this pull request Sep 24, 2021
Fix WorkspaceNew in linkingConfig since it's a screen not a modal

(cherry picked from commit 14e3a95)
@OSBotify
Copy link
Contributor

🚀 Cherry-picked to staging by @marcaaron in version: 1.1.2-4 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@kevinksullivan
Copy link
Contributor

Tested internally using [email protected]

We can check this one off!

RPReplay_Final1632513473.MP4

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @timszot in version: 1.1.2-7 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @marcaaron in version: 1.1.2-9 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @timszot in version: 1.1.3-1 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants