-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: System message shows undefined when selecting an already selected list value #55118
Conversation
@dubielzyk-expensify @dukenv0307 One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
The functionality looks good to me 👍 |
type EditReportFieldDropdownPageProps = EditReportFieldDropdownPageComponentProps; | ||
|
||
function EditReportFieldDropdownPage({onSubmit, fieldKey, fieldValue, fieldOptions}: EditReportFieldDropdownPageProps) { | ||
function EditReportFieldDropdownPage({onSubmit, fieldKey, fieldValue, fieldOptions}: EditReportFieldDropdownPageComponentProps) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should use EditReportFieldDropdownPageProps
name
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have changed the name
This step in test 1 section is incorrect. It should be Verify that there is no system message for selecting the same report field value |
Sorry, I meant to say no system message. I have corrected the error. |
Reviewer Checklist
Screenshots/VideosAndroid: NativeScreen.Recording.2025-01-13.at.10.57.23.movAndroid: mWeb ChromeScreen.Recording.2025-01-13.at.10.54.52.moviOS: NativeScreen.Recording.2025-01-13.at.11.00.51.moviOS: mWeb SafariScreen.Recording.2025-01-13.at.10.53.42.movMacOS: Chrome / SafariScreen.Recording.2025-01-13.at.10.48.55.movMacOS: DesktopScreen.Recording.2025-01-13.at.11.04.10.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/grgia in version: 9.0.86-0 🚀
|
🚀 Deployed to staging by https://github.com/grgia in version: 9.0.86-0 🚀
|
🚀 Deployed to production by https://github.com/mountiny in version: 9.0.86-3 🚀
|
Explanation of Change
Don't make a BE request (
Report_SetFields
) when a user selects the same report field value from a list.Fixed Issues
$ #47067
PROPOSAL: #47067 (comment)
Tests
Same as test steps
Offline tests
Applies only for Test 1
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
Set up before executing test 1, and 2
Test 1
Report_SetFields
API call in Dev tools > Networks tabTest 2
Report_SetFields
API call in Dev tools > Networks tabchanged list fields from A to B
orchanged list fields to C
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android.mp4
Android: mWeb Chrome
Android.chrome.mp4
iOS: Native
ios.mp4
iOS: mWeb Safari
ios.safari.mp4
MacOS: Chrome / Safari
Web.mp4
MacOS: Desktop
destop.mp4