-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update react-navigation to latest versions #5515
Conversation
|
Tested on web, seems to work fine |
Are we waiting for the E2E iOS tests to merge? |
Yep, since we updated dependencies we should let E2E finish |
Okay, E2E tests passed and the workflow run seems to be stuck on complete job. So I'm going to merge this. |
(cherry picked from commit f01e822)
🚀 Cherry-picked to staging by @roryabraham in version: 1.1.2-5 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
@marcaaron Will this be tested internally? We tried testing this on our side and there's only 1 option displayed for public domain accounts (gmail) and we're unable to use the applause.expensifail domain because it asks us to verify the account first |
@isagoico we tested this pretty thoroughly on staging, so feel free to check it off on the checklist. In the near future, we'll probably add testing for this flow to the regression suite. |
🚀 Deployed to staging by @roryabraham in version: 1.1.2-9 🚀
|
Details
There is a bug in the react navigation library that has already been fixed and we just need to update.
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/178594
Tests
npm i && npm run web
QA Steps
Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android