Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update react-navigation to latest versions #5515

Merged
merged 1 commit into from
Sep 24, 2021

Conversation

marcaaron
Copy link
Contributor

@marcaaron marcaaron commented Sep 24, 2021

Details

There is a bug in the react navigation library that has already been fixed and we just need to update.

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/178594

Tests

  1. npm i && npm run web
  2. Sign out of NewDot
  3. Sign up for a new account in OldDot on a mobile web (small width on Chrome or iPhone user agent in safari or iOS simulator)
  4. Tap the first link
  5. Verify you are brought to the workspace page
  6. Verify you do not see a white screen

QA Steps

  1. Sign out of NewDot
  2. Sign up for a new account in OldDot on a mobile web (use actual device)
  3. Tap the first link
  4. Verify you are brought to the workspace page
  5. Verify you do not see a white screen
  6. Repeat 10+ times to verify the white screen can't happen

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

@marcaaron marcaaron requested a review from a team as a code owner September 24, 2021 20:14
@marcaaron marcaaron self-assigned this Sep 24, 2021
@MelvinBot MelvinBot requested review from aldo-expensify and removed request for a team September 24, 2021 20:14
@github-actions
Copy link
Contributor

⚠️ ⚠️ Heads up! This pull request has the CP Staging label. ⚠️ ⚠️
Merging it will cause it to be immediately deployed to staging, even if the open StagingDeployCash deploy checklist is locked.

@aldo-expensify
Copy link
Contributor

aldo-expensify commented Sep 24, 2021

Tested on web, seems to work fine

@aldo-expensify
Copy link
Contributor

Are we waiting for the E2E iOS tests to merge?

@roryabraham
Copy link
Contributor

Yep, since we updated dependencies we should let E2E finish

@roryabraham
Copy link
Contributor

Okay, E2E tests passed and the workflow run seems to be stuck on complete job. So I'm going to merge this.

@roryabraham roryabraham merged commit f01e822 into main Sep 24, 2021
@roryabraham roryabraham deleted the marcaaron-updateReactNavigation branch September 24, 2021 21:14
github-actions bot pushed a commit that referenced this pull request Sep 24, 2021
@OSBotify
Copy link
Contributor

🚀 Cherry-picked to staging by @roryabraham in version: 1.1.2-5 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@isagoico
Copy link

@marcaaron Will this be tested internally? We tried testing this on our side and there's only 1 option displayed for public domain accounts (gmail) and we're unable to use the applause.expensifail domain because it asks us to verify the account first
image

@roryabraham
Copy link
Contributor

@isagoico we tested this pretty thoroughly on staging, so feel free to check it off on the checklist. In the near future, we'll probably add testing for this flow to the regression suite.

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @timszot in version: 1.1.2-7 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @roryabraham in version: 1.1.2-9 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @timszot in version: 1.1.3-1 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants