Redirect user for new virtual card after Fraud flow #55163

narefyev91 · 2025-01-13T12:59:20Z

Explanation of Change

We do automatically reissue a new virtual card when a cardholder replaces an existing one. From the original docs we should land user on the page showing the new virtual card.

Fixed Issues

$ #52953
PROPOSAL: #52953 (comment)

Tests

User has assigned themselves a virtual card.
Go to staging.new.expensify.com
Go to Wallet.
Click on the card.
Click Report virtual card fraud.
Click Deactivate card.
Enter magic code.
Verify that user will be landed on a new virtual card details page

Verify that no errors appear in the JS console

Offline tests

No changes

QA Steps

User has assigned themselves a virtual card.
Go to staging.new.expensify.com
Go to Wallet.
Click on the card.
Click Report virtual card fraud.
Click Deactivate card.
Enter magic code.
Verify that user will be landed on a new virtual card details page

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

android-web.mov

iOS: Native

ios.mov

iOS: mWeb Safari

ios-web.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

melvin-bot · 2025-01-13T14:28:42Z

@fedirjh Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

fedirjh · 2025-01-15T19:44:51Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

CleanShot.2025-01-20.at.20.58.26.mp4

Android: mWeb Chrome

CleanShot.2025-01-20.at.17.37.01.mp4

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

CleanShot.2025-01-20.at.16.21.07.mp4

fedirjh · 2025-01-16T20:54:47Z

@narefyev91 I wasn’t able to get virtual cards, how did you manage to get it working ? Thank you.

narefyev91 · 2025-01-17T07:45:11Z

@narefyev91 I wasn’t able to get virtual cards, how did you manage to get it working ? Thank you.

As i remember @robertjchen helped me to setup virtual cards to my workspace

fedirjh · 2025-01-17T21:59:30Z

@narefyev91 I have successfully enabled the virtual cards. However, there is a not found view displayed before the navigation happen, can we do something about that ?

fedirjh · 2025-01-17T22:21:04Z

@narefyev91 Probably we can address this bug with something similar to this :

const prevVirtualCard = usePrevious(virtualCard);

...

    // if (isEmptyObject(virtualCard)) {
    if (isEmptyObject(virtualCard) && isEmptyObject(prevVirtualCard)) {

shawnborton · 2025-01-20T14:55:35Z

What's the latest on this one?

fedirjh

Looks good to me

fedirjh · 2025-01-20T20:54:36Z

What's the latest on this one?

@shawnborton it's ready to get merged.

OSBotify · 2025-01-21T06:14:10Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-01-21T08:30:38Z

🚀 Deployed to staging by https://github.com/lakchote in version: 9.0.88-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

izarutskaya · 2025-01-22T10:15:12Z

@narefyev91 Found issue on mWeb only #53996

https://platform.applause.com/services/links/v1/external/08a577665d30fa05ece01ea873bffd1f0512ffe40b95d9431e091d9d27745caa

narefyev91 · 2025-01-22T10:33:53Z

@narefyev91 Found issue on mWeb only #53996

https://platform.applause.com/services/links/v1/external/08a577665d30fa05ece01ea873bffd1f0512ffe40b95d9431e091d9d27745caa

@izarutskaya i see on your video - that you tested on prod url - new.expensify.com - was it already deployed to prod? Do you have the same issue on staging?

github-actions · 2025-01-23T18:06:08Z

🚀 Deployed to production by https://github.com/puneetlath in version: 9.0.88-7 🚀

platform	result
🤖 android 🤖	true ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	success ✅

Redirect user for new virtual card after Fraud flow

ad3d9e1

narefyev91 marked this pull request as ready for review January 13, 2025 14:28

narefyev91 requested a review from a team as a code owner January 13, 2025 14:28

melvin-bot bot requested review from fedirjh and removed request for a team January 13, 2025 14:28

narefyev91 added 3 commits January 20, 2025 13:59

Merge branch 'refs/heads/main' into update-fraud-flow-for-virtual-card

c7bdbae

update logic to prevent getting not found page

251f78c

fix eslint

29bd5c2

shawnborton mentioned this pull request Jan 20, 2025

[HOLD for payment 2025-02-07] [$250] Wallet - "It's not here" error is briefly shown when deactivating a virtual card #53996

Open

7 tasks

fedirjh approved these changes Jan 20, 2025

View reviewed changes

melvin-bot bot requested a review from lakchote January 20, 2025 20:53

lakchote approved these changes Jan 21, 2025

View reviewed changes

lakchote merged commit f51798b into Expensify:main Jan 21, 2025
17 checks passed

github-actions bot mentioned this pull request Jan 21, 2025

Deploy Checklist: New Expensify 2025-01-21 #55507

Closed

53 tasks

melvin-bot bot mentioned this pull request Jan 23, 2025

[HOLD for payment 2025-01-30] [$250] Wallet - Deactivated card is not removed from Wallet when it is deactivated in Wallet page #52953

Open

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Redirect user for new virtual card after Fraud flow #55163

Redirect user for new virtual card after Fraud flow #55163

narefyev91 commented Jan 13, 2025 •

edited

Loading

melvin-bot bot commented Jan 13, 2025

fedirjh commented Jan 15, 2025 •

edited

Loading

fedirjh commented Jan 16, 2025

narefyev91 commented Jan 17, 2025

fedirjh commented Jan 17, 2025

fedirjh commented Jan 17, 2025

shawnborton commented Jan 20, 2025

fedirjh left a comment

fedirjh commented Jan 20, 2025

OSBotify commented Jan 21, 2025

github-actions bot commented Jan 21, 2025

izarutskaya commented Jan 22, 2025

narefyev91 commented Jan 22, 2025

github-actions bot commented Jan 23, 2025

Redirect user for new virtual card after Fraud flow #55163

Redirect user for new virtual card after Fraud flow #55163

Conversation

narefyev91 commented Jan 13, 2025 • edited Loading

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jan 13, 2025

fedirjh commented Jan 15, 2025 • edited Loading

Reviewer Checklist

Screenshots/Videos

fedirjh commented Jan 16, 2025

narefyev91 commented Jan 17, 2025

fedirjh commented Jan 17, 2025

fedirjh commented Jan 17, 2025

shawnborton commented Jan 20, 2025

fedirjh left a comment

Choose a reason for hiding this comment

fedirjh commented Jan 20, 2025

OSBotify commented Jan 21, 2025

github-actions bot commented Jan 21, 2025

izarutskaya commented Jan 22, 2025

narefyev91 commented Jan 22, 2025

github-actions bot commented Jan 23, 2025

narefyev91 commented Jan 13, 2025 •

edited

Loading

fedirjh commented Jan 15, 2025 •

edited

Loading