Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sort the People list in the workspace by the display name and make it scrollable #5517

Merged
merged 2 commits into from
Sep 24, 2021
Merged

sort the People list in the workspace by the display name and make it scrollable #5517

merged 2 commits into from
Sep 24, 2021

Conversation

puneetlath
Copy link
Contributor

@puneetlath puneetlath commented Sep 24, 2021 •
edited
Loading

Details

There are two problems with the People page in the Workspace on NewDot:

  1. The list isn't sorted. This PR sorts the list based on the display name.
  2. The list can't be scrolled, so once it gets longer than the page, you can't see the people below the fold. This PR makes it scrollable.

Fixed Issues

$ #5514
$ https://github.com/Expensify/Expensify/issues/178498

Tests

QA Steps

  1. Go into a workspace
  2. Go to the People tab
  3. Add enough users that there are more than fit on the page
  4. Make sure the list is sorted alphabetically
  5. Make sure you're able to scroll the list to see all the members

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Screen Shot 2021-09-24 at 5 53 43 PM

Mobile Web

image

Desktop

image

iOS

image

Android

image

@puneetlath puneetlath self-assigned this Sep 24, 2021
@puneetlath puneetlath changed the title sort the People list in the workspace by the display name sort the People list in the workspace by the display name and make it scrollable Sep 24, 2021
@puneetlath puneetlath marked this pull request as ready for review September 24, 2021 22:41
@puneetlath puneetlath requested a review from a team as a code owner September 24, 2021 22:41
@MelvinBot MelvinBot requested review from nickmurray47 and removed request for a team September 24, 2021 22:41
nickmurray47
nickmurray47 approved these changes Sep 24, 2021
View reviewed changes
Copy link
Contributor

@nickmurray47 nickmurray47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@nickmurray47 nickmurray47 merged commit b4c876a into main Sep 24, 2021
@nickmurray47 nickmurray47 deleted the puneet-workspace-people branch September 24, 2021 23:15
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify OSBotify mentioned this pull request Sep 28, 2021
Closed
16 tasks
@mvtglobally
Copy link

@puneetlath @nickmurray47 If you need us to QA this PR, can you please add testing steps

@puneetlath
Copy link
Contributor Author

Sorry about that @mvtglobally! QA steps have been added!

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @nickmurray47 in version: 1.1.2-9 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @timszot in version: 1.1.3-1 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@0xmiros 0xmiros mentioned this pull request Nov 3, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickmurray47 nickmurray47 nickmurray47 approved these changes

Assignees

@puneetlath puneetlath

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@puneetlath @OSBotify @mvtglobally @nickmurray47