-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Internal QA]: Fix bank name pick from url during goBack from export item #55209
[Internal QA]: Fix bank name pick from url during goBack from export item #55209
Conversation
@dukenv0307 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
src/pages/workspace/accounting/qbo/export/QuickbooksExportConfigurationPage.tsx
Outdated
Show resolved
Hide resolved
Reviewer Checklist
Screenshots/VideosAndroid: NativeScreen.Recording.2025-01-16.at.15.10.55.movAndroid: mWeb ChromeScreen.Recording.2025-01-16.at.15.05.37.moviOS: NativeScreen.Recording.2025-01-16.at.15.07.43.moviOS: mWeb SafariScreen.Recording.2025-01-16.at.14.59.58.movMacOS: Chrome / SafariScreen.Recording.2025-01-16.at.14.58.45.movMacOS: DesktopScreen.Recording.2025-01-16.at.15.14.30.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/mountiny in version: 9.0.87-0 🚀
|
Tested and works! |
I think we need to adjust this so we still use Or alternate solution here - #55417 (comment) |
Thank you! We can revert the redo this! |
🚀 Deployed to production by https://github.com/Beamanator in version: 9.0.87-3 🚀
|
Explanation of Change
When we use bank name with spaces - like
oauth.americanexpressfdx.com 2003
in URL - we should not usegetUrlWithBackToParam
- because URL already have ?oauth.americanexpressfdx.com%20003 (%20
is space)And using getUrlWithBackToParam transform % - to %25. Which makes backTo route incorrect:
Currently route with bug - oauth.americanexpressfdx.com%25202003%2F21809430
Correct one - oauth.americanexpressfdx.com%202003%2F21809430
For test purpose:
Amex card:
In WorkspaceCompanyCardsList - add this line:
Fixed Issues
$ #54371
PROPOSAL:
Tests
Pick mock data from above section.
Offline tests
No changes
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
android.mov
Android: mWeb Chrome
android-web.mov
iOS: Native
ios.mov
iOS: mWeb Safari
ios-web.mov
MacOS: Chrome / Safari
Screen.Recording.2025-01-14.at.16.27.25.mov
MacOS: Desktop
desktop.mov