-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[No QA] Update en.ts #55339
[No QA] Update en.ts #55339
Conversation
Adding the selling point about saving on your Expensify bill
@ Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Can I see how this change looks? I want to see if the copy I added is a bit too long. If it helps, this is where I saw it but I'm not sure if it's anywhere else! ![]() Thanks so much for your help, @pecanoro ! |
🚧 @pecanoro has triggered a test build. You can view the workflow run here. |
🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪 |
@jamesdeanexpensify You should be able to see the new copy using the ad-hoc web build here! |
Reviewer Checklist
Screenshots/VideosAndroid: NativeAndroid: mWeb ChromeiOS: NativeiOS: mWeb SafariMacOS: Chrome / SafariMacOS: Desktop |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Doesn't look too long or wordy - what do you think? |
🚀 Deployed to staging by https://github.com/pecanoro in version: 9.0.87-0 🚀
|
🚀 Deployed to production by https://github.com/Beamanator in version: 9.0.87-3 🚀
|
Adding the selling point about saving on your Expensify bill
Explanation of Change
Fixed Issues
$
PROPOSAL:
Tests
Offline tests
QA Steps
[No QA]
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop