-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[no QA] Adding HelpDot images for NewDot direct feeds #55356
Conversation
This comment was marked as off-topic.
This comment was marked as off-topic.
@c3024 @strepanier03 One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
@strepanier03 / @c3024 you can just approve here to assign internal engineer as this is just adding images for the help site. |
A preview of your ExpensifyHelp changes have been deployed to https://409daa91.helpdot.pages.dev ⚡️ |
Added one more direct feed image. This is good for review now! |
This comment was marked as off-topic.
This comment was marked as off-topic.
@srikarparsi @VictoriaExpensify One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
🎯 @allgandalf, thanks for reviewing and testing this PR! 🎉 An E/App issue has been created to issue payment here: #55400. |
Reviewer Checklist
|
No concierge review needed here, this is just adding images |
This comment was marked as off-topic.
This comment was marked as off-topic.
@srikarparsi @zanyrenney One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
🎯 @shubham1206agra, thanks for reviewing and testing this PR! 🎉 An E/App issue has been created to issue payment here: #55401. |
all set for your review when you have a sec @srikarparsi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good!
TY! |
🚀 Deployed to staging by https://github.com/srikarparsi in version: 9.0.88-0 🚀
|
🚀 Deployed to production by https://github.com/puneetlath in version: 9.0.88-7 🚀
|
Explanation of Change
Adding HelpDot images for NewDot direct feeds
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/439387
Tests
N/A
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videosundefined