[CP Staging] Fix undefined inside backTo parameter for export accounts #55472

narefyev91 · 2025-01-20T09:37:58Z

Explanation of Change

We could not use backTo with getUrlWithBackToParam for company cards logic - it will encodeURIComponent each time we pass backTo to the route - which will lead to %252025202520 - inside the route and we would never get the correct value like %20.
Problem is coming from backTo = 'undefined' - now if param is not passing - it will have type string. We just need to add check logic to prevent using backTo if it's not a valid string.

Fixed Issues

$ #54371, #55417
PROPOSAL:

Tests

Go to Accounting > Netsuite
Click on Export
Click back arrow

Verify that no errors appear in the JS console

Offline tests

No changes

QA Steps

Go to Accounting > Netsuite
Click on Export
Click back arrow

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

android-web.mov

iOS: Native

ios.mov

iOS: mWeb Safari

ios-web.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

melvin-bot · 2025-01-20T09:38:03Z

@dukenv0307 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

dukenv0307 · 2025-01-20T10:18:56Z

should we remove backTo in the url if it's undefined? @narefyev91

narefyev91 · 2025-01-20T10:33:54Z

should we remove backTo in the url if it's undefined? @narefyev91

i think it's not exist in the url

narefyev91 · 2025-01-20T11:20:46Z

@dukenv0307 we can as well pass one more prop to getUrlWithBackToParam - shouldEncodeURIComponent - and make it true by default, and for export routes just use false

function getUrlWithBackToParam<TUrl extends string>(url: TUrl, backTo?: string, shouldEncodeURIComponent = true): ${TUrl} { const backToParam = backTo ? (${url.includes('?') ? '&' : '?'}backTo=${shouldEncodeURIComponent ? encodeURIComponent(backTo) : backTo}as const) : ''; return${url}${backToParam}as${TUrl}; }

And usage will be like this:

POLICY_ACCOUNTING_SAGE_INTACCT_EXPORT: { route: 'settings/workspaces/:policyID/accounting/sage-intacct/export', getRoute: (policyID: string, backTo?: string) => getUrlWithBackToParam(settings/workspaces/${policyID}/accounting/sage-intacct/export as const, backTo, false), },

Beamanator · 2025-01-20T14:21:29Z

Howdy y'all - can we please get this moving so we can unblock deploy? 🙏 @dukenv0307 got any concerns with the current implementation?

dukenv0307 · 2025-01-20T14:23:33Z

@Beamanator I'm reviewing

dukenv0307 · 2025-01-20T14:24:26Z

The current implementation looks good to me

dukenv0307 · 2025-01-20T14:24:46Z

I'll finish the checklist soon

Beamanator · 2025-01-20T14:30:59Z

Ok great thanks so much 🙏

dukenv0307 · 2025-01-20T14:44:12Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

Screen.Recording.2025-01-20.at.21.37.43.mov

iOS: Native

Screen.Recording.2025-01-20.at.21.38.49.mov

iOS: mWeb Safari

Screen.Recording.2025-01-20.at.21.37.09.mov

MacOS: Chrome / Safari

Screen.Recording.2025-01-20.at.21.34.48.mov

MacOS: Desktop

Screen.Recording.2025-01-20.at.21.43.22.mov

dukenv0307

LGTM

Beamanator

LGTM!

OSBotify · 2025-01-20T14:56:41Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

…ck-to [CP Staging] Fix undefined inside backTo parameter for export accounts (cherry picked from commit 791217f) (CP triggered by Beamanator)

github-actions · 2025-01-20T15:43:48Z

🚀 Cherry-picked to staging by https://github.com/Beamanator in version: 9.0.87-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

github-actions · 2025-01-21T08:09:36Z

🚀 Deployed to production by https://github.com/Beamanator in version: 9.0.87-3 🚀

platform	result
🤖 android 🤖	true ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	success ✅

narefyev91 added 2 commits January 20, 2025 11:23

Fix undefined inside backTo parameter for export accounts

36163ca

check for normal null and undefined as well

1099518

narefyev91 requested a review from a team as a code owner January 20, 2025 09:37

melvin-bot bot requested a review from dukenv0307 January 20, 2025 09:38

melvin-bot bot removed the request for review from a team January 20, 2025 09:38

move logic to getUrlWithBackToParam

568eab6

dukenv0307 approved these changes Jan 20, 2025

View reviewed changes

melvin-bot bot requested a review from mountiny January 20, 2025 14:44

Beamanator approved these changes Jan 20, 2025

View reviewed changes

Beamanator changed the title ~~Fix undefined inside backTo parameter for export accounts~~ [CP Staging] Fix undefined inside backTo parameter for export accounts Jan 20, 2025

Beamanator merged commit 791217f into Expensify:main Jan 20, 2025
18 checks passed

github-actions bot added the CP Staging marks PRs that have been CP'd to staging label Jan 20, 2025

github-actions bot mentioned this pull request Jan 20, 2025

Deploy Checklist: New Expensify 2025-01-17 #55396

Closed

60 tasks

Beamanator mentioned this pull request Jan 21, 2025

Netsuite/Intacct/Xero - Page not found when click Back error on Export tab #55417

Closed

8 tasks

melvin-bot bot mentioned this pull request Jan 21, 2025

[HOLD for payment 2025-01-30] [HOLD for payment 2025-01-28] [HOLD for payment 2025-01-15] "No Accounts" Page for Unsupported Card-Level Export Options #54371

Closed

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[CP Staging] Fix undefined inside backTo parameter for export accounts #55472

[CP Staging] Fix undefined inside backTo parameter for export accounts #55472

narefyev91 commented Jan 20, 2025 •

edited

Loading

melvin-bot bot commented Jan 20, 2025

dukenv0307 commented Jan 20, 2025

narefyev91 commented Jan 20, 2025 •

edited

Loading

narefyev91 commented Jan 20, 2025 •

edited

Loading

Beamanator commented Jan 20, 2025

dukenv0307 commented Jan 20, 2025

dukenv0307 commented Jan 20, 2025

dukenv0307 commented Jan 20, 2025

Beamanator commented Jan 20, 2025

dukenv0307 commented Jan 20, 2025

dukenv0307 left a comment

Beamanator left a comment

OSBotify commented Jan 20, 2025

github-actions bot commented Jan 20, 2025

github-actions bot commented Jan 21, 2025

[CP Staging] Fix undefined inside backTo parameter for export accounts #55472

[CP Staging] Fix undefined inside backTo parameter for export accounts #55472

Conversation

narefyev91 commented Jan 20, 2025 • edited Loading

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jan 20, 2025

dukenv0307 commented Jan 20, 2025

narefyev91 commented Jan 20, 2025 • edited Loading

narefyev91 commented Jan 20, 2025 • edited Loading

Beamanator commented Jan 20, 2025

dukenv0307 commented Jan 20, 2025

dukenv0307 commented Jan 20, 2025

dukenv0307 commented Jan 20, 2025

Beamanator commented Jan 20, 2025

dukenv0307 commented Jan 20, 2025

Reviewer Checklist

Screenshots/Videos

dukenv0307 left a comment

Choose a reason for hiding this comment

Beamanator left a comment

Choose a reason for hiding this comment

OSBotify commented Jan 20, 2025

github-actions bot commented Jan 20, 2025

github-actions bot commented Jan 21, 2025

narefyev91 commented Jan 20, 2025 •

edited

Loading

narefyev91 commented Jan 20, 2025 •

edited

Loading

narefyev91 commented Jan 20, 2025 •

edited

Loading