-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HelpDot Audit: Adding dummy pages to hidden section of helpsite #55826
Conversation
Concierge reviewer checklist:
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member? |
@mananjadhav @johncschuster One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
A preview of your ExpensifyHelp changes have been deployed to https://c6138564.helpdot.pages.dev ⚡️ |
Since these are in a hidden folder, you won't be able to use the helpdot.pages.dev nav to view the preview. You'd need to visit the URL directly, here is one you can use: https://ece29007.helpdot.pages.dev/Hidden/[file-name] |
fix image
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
When I review these pages, they don't have any content, so there's nothing really to see. Coming from the comment you linked in the OP, it seems like that is by design. Please let me know if I'm off base! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked all the PR files and I don't see anything specific to review. But the checklist check will still fail. @stephanieelliott let me know if checklist is needed.
Approving this so that an Internal engineer is assigned.
Concierge reviewer checklist:
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member? |
@madmax330 @greg-schroeder One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
🎯 @mananjadhav, thanks for reviewing and testing this PR! 🎉 An E/App issue has been created to issue payment here: #55884. |
Ah yes so there is no actual content that needs to be reviewed, these are just blank pages being added. |
🚀 Deployed to staging by https://github.com/johncschuster in version: 9.0.91-0 🚀
|
🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.0.91-2 🚀
|
Explanation of Change
As part of the HelpDot audit and testing to reduce AgentZero escalations, we're seeding the help site with a bunch of dummy images (this comment has more context_. These pages will eventuall be deleted once we are done testing.
Fixed Issues
$
PROPOSAL:
N/A
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop