Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Bump Onyx to 2.0.91 / Enable skippable collection member IDs in Onyx" #56012

Merged

Conversation

neil-marcellini
Copy link
Contributor

Reverts #54163. It's causing a test to fail consistently in GH actions on main.

Fixed Issues

#56001

@neil-marcellini neil-marcellini self-assigned this Jan 29, 2025
@neil-marcellini neil-marcellini requested a review from a team as a code owner January 29, 2025 22:13
@melvin-bot melvin-bot bot requested review from madmax330 and removed request for a team January 29, 2025 22:13
Copy link

melvin-bot bot commented Jan 29, 2025

@madmax330 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Copy link
Contributor

@mountiny mountiny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Straight revert

@mountiny mountiny merged commit 6670a4e into main Jan 29, 2025
15 of 20 checks passed
@mountiny mountiny deleted the revert-54163-feature/onyx-skippable-collection-member-ids branch January 29, 2025 22:18
Copy link

melvin-bot bot commented Jan 29, 2025

@mountiny looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@mountiny
Copy link
Contributor

Straight revert to fix failing test on main

@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

Copy link
Contributor

🚀 Deployed to staging by https://github.com/mountiny in version: 9.0.92-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅
🤖🔄 android HybridApp 🤖🔄 success ✅
🍎🔄 iOS HybridApp 🍎🔄 success ✅

Copy link
Contributor

🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.0.92-6 🚀

platform result
🤖 android 🤖 true ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅
🤖🔄 android HybridApp 🤖🔄 failure ❌
🍎🔄 iOS HybridApp 🍎🔄 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants