Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix identity validation in VBA flow #5629

Merged
merged 3 commits into from
Oct 4, 2021
Merged

Fix identity validation in VBA flow #5629

merged 3 commits into from
Oct 4, 2021

Conversation

marcaaron
Copy link
Contributor

@marcaaron marcaaron commented Oct 4, 2021 •
edited
Loading

Details

Fixes date of birth and other required fields in identity validation for VBA flow

Fixed Issues (Related to this PR)

#5259

Tests / QA Steps

  1. Submit empty form on the Personal information step
  2. Verify all fields show with an error message
  3. Verify the date of birth field says to enter a valid date of birth when no dob is provided
  4. Test again on the Beneficial Owners step
  5. Make sure you can fix these errors and continue past to the next screen

2021-10-04_07-45-11

2021-10-04_07-42-12

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

@marcaaron marcaaron self-assigned this Oct 4, 2021
@marcaaron marcaaron requested a review from a team as a code owner October 4, 2021 17:45
@MelvinBot MelvinBot requested review from timszot and removed request for a team October 4, 2021 17:46
@marcaaron marcaaron marked this pull request as draft October 4, 2021 17:49
@marcaaron marcaaron marked this pull request as ready for review October 4, 2021 17:57
@luacmartins luacmartins self-requested a review October 4, 2021 18:36
luacmartins
luacmartins approved these changes Oct 4, 2021
View reviewed changes
Copy link
Contributor

@luacmartins luacmartins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and tested well!

aldo-expensify
aldo-expensify approved these changes Oct 4, 2021
View reviewed changes
Copy link
Contributor

@aldo-expensify aldo-expensify left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested on web.

@timszot timszot merged commit c312069 into main Oct 4, 2021
@timszot timszot deleted the marcaaron-fixIdentityValidate branch October 4, 2021 23:33
@OSBotify
Copy link
Contributor

OSBotify commented Oct 4, 2021

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify OSBotify mentioned this pull request Oct 6, 2021
Closed
13 tasks
@OSBotify
Copy link
Contributor

OSBotify commented Oct 6, 2021

🚀 Deployed to staging by @timszot in version: 1.1.5-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Oct 7, 2021

🚀 Deployed to production by @chiragsalian in version: 1.1.6-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aldo-expensify aldo-expensify aldo-expensify approved these changes

@luacmartins luacmartins luacmartins approved these changes

@timszot timszot timszot approved these changes

Assignees

@marcaaron marcaaron

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@marcaaron @OSBotify @timszot @luacmartins @aldo-expensify