Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update copy for remove members #5654

Merged
merged 3 commits into from
Oct 5, 2021
Merged

Update copy for remove members #5654

merged 3 commits into from
Oct 5, 2021

Conversation

TomatoToaster
Copy link
Contributor

@TomatoToaster TomatoToaster commented Oct 5, 2021

@marcochavezf, please review when you get the chance (easy review!)

Details

Simple copy change for confirming when you want to remove members.

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/180131

Tests

QA Steps

  1. Log into an account that has a Workspace in NewDot. You can create one if you don't already have one by clicking on the green plus in the bottom left. It doesn't need to have a bank account set up.
  2. Go to Workspace's Settings -> People
    image
  3. Invite a new user if you are the only member in the workspace. After you do. Select that user and try to remove them. Verify that confirm modal that pops up has the new copy (in the screenshots below).

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

image
image

Mobile

image
image

Sorry, something went wrong.

Unverified

No user is associated with the committer email.
@TomatoToaster TomatoToaster self-assigned this Oct 5, 2021
Amal Nazeem added 2 commits October 5, 2021 12:01

Unverified

No user is associated with the committer email.

Unverified

No user is associated with the committer email.
@TomatoToaster TomatoToaster marked this pull request as ready for review October 5, 2021 16:18
@TomatoToaster TomatoToaster requested a review from a team as a code owner October 5, 2021 16:18
@MelvinBot MelvinBot requested review from marcochavezf and removed request for a team October 5, 2021 16:18
@marcochavezf
Copy link
Contributor

👍🏽

Screen Shot 2021-10-05 at 14 12 45

Screen Shot 2021-10-05 at 14 12 12

@marcochavezf marcochavezf merged commit b550d52 into main Oct 5, 2021
@marcochavezf marcochavezf deleted the amal-delete-members-copy branch October 5, 2021 19:14
@OSBotify
Copy link
Contributor

OSBotify commented Oct 5, 2021

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

OSBotify commented Oct 6, 2021

🚀 Deployed to staging by @marcochavezf in version: 1.1.5-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Oct 7, 2021

🚀 Deployed to production by @chiragsalian in version: 1.1.6-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants