Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update copy for 'Invite people' step #5662

Merged
merged 1 commit into from
Oct 5, 2021
Merged

Update copy for 'Invite people' step #5662

merged 1 commit into from
Oct 5, 2021
+4 −4

Conversation

francoisl
Copy link
Contributor

cc @kevinksullivan

Details

Replace the use of the words "colleagues" and "people" to "member" in the Invite step.

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/180154

QA Steps / Tests

  1. Open an existing Workspace, or create one
  2. In the Workspace editor, open the People section
  3. Click the Invite button
  4. Make sure the title of the right hand panel that opens is Invite New Members (Invitar nuevos miembros in Spanish)
  5. Make sure that the text below the title reads Invite new members to your workspace. (Invita nuevos miembros a tu espacio de trabajo. in Spanish)

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

  • English
    image

  • Spanish
    image

Sorry, something went wrong.

@francoisl francoisl requested a review from a team as a code owner October 5, 2021 18:33
@MelvinBot MelvinBot requested review from Jag96 and removed request for a team October 5, 2021 18:34
@Jag96 Jag96 merged commit 2330bb9 into main Oct 5, 2021
@Jag96 Jag96 deleted the francois-inviteMemberCopyChange branch October 5, 2021 19:34
@OSBotify
Copy link
Contributor

OSBotify commented Oct 5, 2021

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify OSBotify mentioned this pull request Oct 6, 2021
Closed
13 tasks
@OSBotify
Copy link
Contributor

OSBotify commented Oct 6, 2021

🚀 Deployed to staging by @Jag96 in version: 1.1.5-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Oct 7, 2021

🚀 Deployed to production by @chiragsalian in version: 1.1.6-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jag96 Jag96

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@francoisl @OSBotify @Jag96