Fix error condition for policy create #5687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
ctkochan22
approved these changes
Oct 7, 2021
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by @TomatoToaster in version: 1.1.7-25 🚀
|
|
The grey "Get the Expensify Card and more" text (#7D8B8F) on white (#FFFFFF) and light grey on focus (#FAFAFA) background has a contrast ratio of 3.52:1 and 3.37:1 accordingly, failing the minimum contrast requirements of 4.50:1. |
|
🚀 Deployed to production by @roryabraham in version: 1.1.8-9 🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CC: @marcaaron @mananjadhav
Details
Fixes this an error that could create a weird experience if our app is offline.
Fixed Issues
Error was caught in PR here: https://github.com/Expensify/App/pull/4481/files#r709771608
Tests
No practical way to test that this error except for Expensify Engineers. To do this you can kill auth in the VM (sudo service auth stop) and try to click the Create New Workspace like in the QA steps (disconnect auth after step 1). You'll see an error and a workspace won't be created.
QA Steps
Make sure policy creation works as it did normally before.
+at the bottom leftTested On
Screenshots
Web