Add currency selector to settings page #5713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgolen
requested changes
Oct 7, 2021
| @@ -43,14 +45,20 @@ class WorkspaceSettingsPage extends React.Component { | |||
| name: props.policy.name, | |||
There was a problem hiding this comment.
props.policy is missing from the propTypes. Can you please add it?
| */ | ||
| getCurrencyItems() { | ||
| const currencyListKeys = _.keys(this.props.currencyList); | ||
| const a = _.map(currencyListKeys, currencyCode => ({ |
There was a problem hiding this comment.
Don't use a short variable and just use return _.map();
There was a problem hiding this comment.
Oh I was debugging this and added it for easy inspection, removing it
| @@ -67,6 +75,19 @@ class WorkspaceSettingsPage extends React.Component { | |||
| this.setState({previewAvatarURL: '', avatarURL: ''}); | |||
| } | |||
|
|
|||
| /** | |||
| * | |||
| size={CONST.AVATAR_SIZE.LARGE} | ||
| DefaultAvatar={() => ( | ||
| <Icon | ||
| src={Workspace} |
There was a problem hiding this comment.
I think this is supposed to be Camera
tgolen
approved these changes
Oct 7, 2021
|
🚀 Deployed to production by @roryabraham in version: 1.1.8-9 🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Fixed Issues
$ GH_LINK
Tests
QA Steps
Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android