Set the fastlane build_app param manageAppVersionAndBuildNumber #5721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewGable
approved these changes
Oct 7, 2021
|
cc @roryabraham I think you'll find this one interesting |
Dal-Papa
approved these changes
Oct 8, 2021
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
Yikes! This will forsure break our NewDot versioning too. I'm going to look into making the same change over there to prevent this same thing happening. |
|
@timszot read your mind, this is new dot 😉 |
|
haha I juuuust realized that 😅 Thanks @timszot!!! |
|
🚀 Deployed to production by @roryabraham in version: 1.1.8-9 🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Xcode 13 added a new "feature" that auto manages the build number for apps. This flag prevents that feature which breaks our versioning. More info here: https://github.com/Expensify/Expensify/issues/180187#issuecomment-938158022
Reference issue: https://github.com/Expensify/Expensify/issues/180187
Tests
Tested in Mobile-E deploy process, will monitor deploys in newDot to make sure this doesn't cause errors.
QA Steps
none